Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: transform datetime to bytes #540

Merged
merged 1 commit into from
Feb 16, 2025
Merged

chore: transform datetime to bytes #540

merged 1 commit into from
Feb 16, 2025

Conversation

mesejo
Copy link
Collaborator

@mesejo mesejo commented Feb 16, 2025

No description provided.

@mesejo mesejo requested a review from dlovell February 16, 2025 17:19
@mesejo mesejo self-assigned this Feb 16, 2025
@mesejo mesejo marked this pull request as ready for review February 16, 2025 17:19
@mesejo mesejo added the ci-test-snowflake Trigger test on the Snowflake backend label Feb 16, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
snowflake 56.92% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/letsql/common/utils/dask_normalize_expr.py 83.13% <ø> (+2.32%) ⬆️

... and 6 files with indirect coverage changes

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 16, 2025

CodSpeed Performance Report

Merging #540 will not alter performance

Comparing feat/fix-snowflake-tokenize (744f4f3) with main (153d90c)

Summary

✅ 2 untouched benchmarks

@dlovell dlovell merged commit a8f1904 into main Feb 16, 2025
14 checks passed
@dlovell dlovell deleted the feat/fix-snowflake-tokenize branch February 16, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlovell dlovell dlovell approved these changes

Assignees

@mesejo mesejo

Labels
ci-test-snowflake Trigger test on the Snowflake backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mesejo @dlovell