-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build system): consolidate YAML/SQL serialization #525
Open
hussainsultan
wants to merge
37
commits into
main
Choose a base branch
from
feat/yaml-compiler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #525 will not alter performanceComparing Summary
|
1a5df96
to
2714aa0
Compare
57d9da0
to
8a25426
Compare
Codecov ReportAttention: Patch coverage is
|
e692ba3
to
d9278bf
Compare
- passes tpch-01-22 - unbound expr only - support builtin ScalarUDF
- removes redundant schema definitions in yaml
- drop IbisYamlCompiler -> YamlExpressionTranslator - drop BuildManager -> ArtifactStore - Add BuildManager as a user-facing class
- add `find_all_backends` method with Read Op support
feat: disable yaml alias/achors refactor: remove unnecessary `_register_expr_schema` in YamlExpressionTranslator refactor: remove unnecessary definitions checks
d9278bf
to
f218d8b
Compare
ghoersti
reviewed
Feb 23, 2025
def compile_expr(self, expr: ir.Expr) -> str: | ||
expr_hash = self.artifact_store.get_expr_hash(expr) | ||
|
||
backends = find_all_sources(expr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hussainsultan This would break with new profiles implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds roundtrip translation of expr to and from YAML and defines what the build artifacts should look like.
• Added
metadata.json
and BuildConfig support (with YAML alias/anchor disabling)• Updated BuildManager to generate SQL plans and support proper SQL formatting
•
kwargs_tuple
in profile so it’s written as a key/value pair in YAML• Split deferred reads and SQL into dedicated YAML files (e.g.
deferred_reads.yaml
,sql.yaml
)• Consolidated redundant YAML schemas in
definitions
field and added aschema_ref
Note: CachedNode is not written in
sql.yaml
ordeferred_reads.yaml
• only caching with SourceStorage is supported
• Improved error handling and adjusted tests (e.g., unmarking xfail tests for deferred reads)
XFail Cases:
•
tests/test_compiler.py::test_ibis_compiler
•
tests/test_letsql_ops.py::{test_memtable, test_memtable_cache}
Reason: MemTable is not serializable
•
tests/test_udf.py::test_built_in_udf
Reason: UDFs do not have the same memory address when pickled/unpickled
Handle in follow-up PRs:
_register.py
for code-based UDF serialization