Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor out hotfixing snowflake #509

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Conversation

mesejo
Copy link
Collaborator

@mesejo mesejo commented Feb 4, 2025

No description provided.

@mesejo mesejo self-assigned this Feb 4, 2025
@mesejo mesejo marked this pull request as draft February 4, 2025 16:59
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 85.36585% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
python/letsql/backends/snowflake/__init__.py 83.56% 12 Missing ⚠️
Flag Coverage Δ
snowflake 57.32% <85.36%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/letsql/backends/let/hotfix.py 89.68% <ø> (-0.17%) ⬇️
python/letsql/backends/snowflake/tests/conftest.py 100.00% <100.00%> (+78.12%) ⬆️
...thon/letsql/backends/snowflake/tests/test_cache.py 100.00% <100.00%> (ø)
python/letsql/common/utils/snowflake_utils.py 65.00% <ø> (+57.68%) ⬆️
python/letsql/backends/snowflake/__init__.py 80.58% <83.56%> (+37.24%) ⬆️

... and 3 files with indirect coverage changes

Copy link

codspeed-hq bot commented Feb 4, 2025

CodSpeed Performance Report

Merging #509 will degrade performances by 37.08%

Comparing chore/remove-snowflake-hotfix (fbe592b) with main (2be47d6)

Summary

⚡ 1 improvements
❌ 1 regressions

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_into_backend_cache 161.7 ms 108.4 ms +49.25%
test_into_backend_duckdb_trino_cached 535.9 ms 851.6 ms -37.08%

@dlovell dlovell self-requested a review February 5, 2025 10:41
@mesejo mesejo added the ci-test-snowflake Trigger test on the Snowflake backend label Feb 5, 2025
@mesejo mesejo marked this pull request as ready for review February 5, 2025 19:03
@mesejo mesejo force-pushed the chore/remove-snowflake-hotfix branch from 3f63ed8 to addee91 Compare February 5, 2025 20:03
@mesejo mesejo added ci-test-snowflake Trigger test on the Snowflake backend and removed ci-test-snowflake Trigger test on the Snowflake backend labels Feb 5, 2025
@mesejo mesejo force-pushed the chore/remove-snowflake-hotfix branch from 575f3e0 to fbe592b Compare February 5, 2025 20:58
@mesejo mesejo added ci-test-snowflake Trigger test on the Snowflake backend and removed ci-test-snowflake Trigger test on the Snowflake backend labels Feb 5, 2025
@mesejo mesejo merged commit e20e590 into main Feb 5, 2025
12 of 14 checks passed
@mesejo mesejo deleted the chore/remove-snowflake-hotfix branch February 5, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-test-snowflake Trigger test on the Snowflake backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants