Explicitly state that we do pre-issuance linting #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygabby
approved these changes
Sep 27, 2024
|
Note that we also say we do pre-issuance linting in 8.7 |
|
It seems to me that since we already talk about this in Section 8.7 this added level of detail in both presence and ordering of operations is duplicative and unnecessarily complex. I think we should either skip this change or remove the pre-issuance linting text from 8.7. |
|
Good point. Section 8.7 of the BRs actually talks about post-issuance linting, so I've updated our Section 8.7 to do the same. Confirmation that our self-audit (cert-checker) does in fact do linting can be found here: https://github.com/letsencrypt/boulder/blob/d17d71cc6ee9d35c2caf98635e0563be9fe0cd2a/cmd/cert-checker/main.go#L348 |
bdaehlie
reviewed
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Section 4.3.1 to mention our pre-issuance linting, which is now required by the BRs. Also rephrase Section 8.7 to mention our post-issuance (rather than pre-issuance) linting, in line with what that section of the BRs cares about.
Fixes #223