Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA: Use Validation Profiles to determine order/authz lifetimes #7989

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aarongable
Copy link
Contributor

@aarongable aarongable commented Jan 30, 2025

Add three new fields to the ra.ValidationProfile structure, representing the profile's pending authorization lifetime (used to assign an expiration when a new authz is created), valid authorization lifetime (used to assign an expiration when an authz is successfully validated), and order lifetime (used to assign an expiration when a new order is created). Remove the prior top-level fields which controlled these values across all orders.

Add a "defaultProfileName" field to the RA as well, to facilitate looking up a default set of lifetimes when the order doesn't specify a profile. If this default name is explicitly configured, always provide it to the CA when requesting issuance, so we don't have to duplicate the default between the two services.

Modify the RA's config struct in a corresponding way: add three new fields to the ValidationProfiles structure, and deprecate the three old top-level fields. Also upgrade the ra.NewValidationProfile constructor to handle these new fields, including doing validation on their values.

Fixes #7605


Warning

Do not merge until an IN-????? ticket has been filed to track the corresponding staging/prod config changes

Base automatically changed from wfe-finalize-unknown-profile to main January 30, 2025 22:10
@aarongable aarongable marked this pull request as ready for review January 30, 2025 22:50
@aarongable aarongable requested a review from a team as a code owner January 30, 2025 22:50
@aarongable aarongable requested a review from jsha January 30, 2025 22:50
Copy link
Contributor

@aarongable, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RA: Allow profile to control aspects of validation such as order/authz lifetime
1 participant