Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latchset workaround #1270

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Latchset workaround #1270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e88f074
Skip TestJoseCompatibility
Jan 20, 2025
923b7b5
appease linter
Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
Changes
=======

UNRELEASED
* Skip TestJoseCompatibility, because latchset/jose recently decided to set `p2c` to
32768, but we do not have the ability to set this number in v1

v1.2.30 28 Jul 2024
* Update minimum required go version to 1.20
* Update tests so that they work on 32-bit systems
Expand Down
6 changes: 6 additions & 0 deletions jwx_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"crypto/ecdsa"
"crypto/rsa"
"fmt"
"os"
"strings"
"testing"

Expand Down Expand Up @@ -90,6 +91,11 @@ func TestDecoderSetting(t *testing.T) {
func TestJoseCompatibility(t *testing.T) {
t.Parallel()

if os.Getenv(`JWX_ENABLE_JOSE_COMPATIBILITY_TESTS`) == "" {
t.Logf("This test is skipped for v1 -- v1 does not have the ability to allow higher number of 'p2c', but new latchset/jose sets it to 32768")
return
}

if testing.Short() {
t.Logf("Skipped during short tests")
return
Expand Down
Loading