-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to GitHub actions #332
Conversation
@lest, I will want to hear your opinion on this. One thing to note, currently publish tasks will not work, as they might require slight adjustment, I've added |
.github/workflows/build.yml
Outdated
- if: env.RPM_GPG_KEY_SECRET != '' | ||
run: echo openssl aes-256-cbc -k ${RPM_GPG_KEY_SECRET} -in secret.asc.enc -out secret.asc -d | ||
|
||
- if: env.RPM_GPG_KEY_PASSPHRASE != '' | ||
run: echo ${RPM_GPG_KEY_PASSPHRASE} > .passphrase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lest, are these steps actually required? I can see sign
target in Makefile
but it appears that it was not used in .travis.ci
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sign
is not used on its own. sign7
and sign8
are used as they are specified as dependencies for publish7
and publish8
.
strategy: | ||
matrix: | ||
version: | ||
- 8 | ||
- 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lest, is there any point in separating publish jobs and run make publish7
& make publish8
separately instead of doing that in single step that includes both of them? (make publish
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can have a single step that includes both with the new approach for caching RPMs between jobs.
@lest, any updates on this? Travis CI has been PITA lately with most of the jobs failing: |
@karlism everything looks alright. I've added all required secrets to the repository, so we can merge it and see it in action. |
Thanks, will try to update some packages to see if everything works as expected. |
@karlism Looks like there are a few issues with getting it fully running. I'm testing and making required adjustments now. |
Looks like publish packages
|
@karlism I got it fixed. |
@lest, thanks! Why did you remove this check? 19b4f67#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721L98 |
@karlism this check resulted in the step being skipped for some reason during my testing. I think we can have it applied to the whole publish_packages job instead of a single step. |
Switch from Travis CI to GitHub actions, I will highlight some of the changes:
Travis CI is slow, not being maintained too much lately and will only get worse over time, so I suggest switching to GitHub actions. Also, it's nice to have one external dependency less.