Fixes #2824 - Expressions require a delimiter of some kind in mixin args #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-dean
changed the title
calvinjuarez
reviewed
Jul 7, 2018
| @@ -953,7 +953,7 @@ var Parser = function Parser(context, imports, fileInfo) { | |||
| arg = entities.variable() || entities.property() || entities.literal() || entities.keyword() || this.call(true); | |||
| } | |||
|
|
|||
| if (!arg) { | |||
| if (!arg || !hasSep) { | |||
There was a problem hiding this comment.
Will this ever evaluate to true? It looks like hasSep isn't touched between hasSep = true and !hasSep. Unless there's some kind of non-linear code happening that would set it.
There was a problem hiding this comment.
It's set per loop. The first time it's true; that's intentional because it doesn't need a separator. Then it continues to be set by the presence of a separator, but depends on what type during the loop. So if ever it finishes without detecting a true separation of args, it should fail... I think. It seems to work? lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2824