passing Parser import errors

[daemonl]

parser.imports stored any errors in .error, but only returned an error to the callback on that last import in the queue.

This commit makes it return the stored error (that.error).

issue #463

Will write a failing test if needed. - Import 2 files, error in the first.

[lukeapage]

Cool, thanks.

[lukeapage]

shouldn't it be that.error || e ?

Do you have any examples of how to reproduce the problem?

[daemonl]

Line 89 takes care of if the error is in the current imported file. that.error || e would throw the last parser error, where just taking that.error will always throw the first error encountered.

This Works:

base.less:
  @import './one';
  @import './two';

one.less:
    SomethingCompletelyInvalid}}

two.less:
  body { background-color: #9f9; }

But not if you include base.less from another file:
entry.less:
@import './base.less'

The lessc tool is fine, and some of the express middleware is fine, the issue is occurring when using grunt-contrib-less which calls:

var parser = new less.Parser(pick(options, lessOptions.parse));

parser.parse(srcCode, function(parse_err, tree) {
  if (parse_err) {
    lessError(parse_err);
  }

  try {
    css = tree.toCSS(pick(options, lessOptions.render));
    callback(css, null);
  } catch (e) {
    lessError(e);
    callback(css, true);
  }
});

I haven't looked at what the others call, but it makes sense by the less code that parser errors in all but the last imported file in another imported file would be completely hidden.

[lukeapage]

ok, sorry didn't look at the source and the diff didn't see line 98. seems like a no brainer.

[lukeapage]

pulled.