Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base path is added to quoted data:uri #361

Closed
iiidefix opened this issue Aug 27, 2011 · 2 comments
Closed

Base path is added to quoted data:uri #361

iiidefix opened this issue Aug 27, 2011 · 2 comments

Comments

@iiidefix
Copy link

similar to issue #258
I could not reopen therefore I filed a new issue

in less.js 1.1.4 basepath is added to quoted data:uris

working:
url(data:...);

not working:
url('data:...');
url("data:...");

The Problem are the slashes which are not required in data uris as seen in http://en.wikipedia.org/wiki/Data_URI_scheme#CSS .

solution replace line 2320 with
if (!/^(?:https?:\/\/|file:\/\/|data:)?/.test(val.value) && paths.length > 0 && typeof(window) !== 'undefined') {

@asolove
Copy link
Contributor

asolove commented Oct 21, 2011

Just ran into this problem as well. The tests already passed because the codepath with the bug was only run in the browser. I just submitted a pull request fixing the issue: #432

cloudhead pushed a commit that referenced this issue Oct 23, 2011
#361: Fix for quoted data URIs getting prepended with path
@neonstalwart neonstalwart mentioned this issue May 15, 2012
@lukeapage
Copy link
Member

fix was merged.. I think this issue is closed. Please comment if not.

stefanklug pushed a commit to stefanklug/carto that referenced this issue Jan 27, 2019
shield-label-position-tolerance (post-Mapnik 2.3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants