-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source map bug introduced in 2.7.0, but passes tests #2896
Comments
This issue should stay open until a Less.js test is added which catches this issue, since the source map tests didn't detect the bug. |
I'm experiencing the same issue. |
better unpublish this version |
It depends. For some the sourcemaps are totally insignificant if compared to for example #2841 of the previous release. |
In case it can help, I could reproduce the issue with something like: Less: .dl-horizontal {
@media (min-width: 768px) {
dt {
float: left;
}
}
} Gulp task: return gulp.src('./src/lib.less')
.pipe(sourcemaps.init())
.pipe(less())
.pipe(sourcemaps.write('.'))
.pipe(gulp.dest(bundleFolder)); |
This just broke my builds, need a patch asap... |
Please fix this bug asap, or I can only froze the version to 2.6.X. |
Production chaos on this side as well... |
Crashes my gulp build as well |
If you're having trouble with a dependency using less as a dependency and simply can't downgrade in package.json. |
Clearly the impact is widespread. It blocked my production release. Yes, please implement a hotfix, and provide workarounds, but in the meantime, for the love of all that is good and holy:
Unless you will have 2.7.1 published within, say, the next hour, nip this in the bud and unpublish. |
Any line of sight for a fix on this yet? |
Fixes #1 - Due to less/less.js#2896
I've published 2.7.1 as a hotfix for 2.7.0, but it's unclear from #2881 if there isn't still an outstanding bug affecting source maps (multiple intersecting bugs from same commit?), or if that was a pre-existing bug which was introduced separately. Please report back if 2.7.1 is working for you. |
- less/less.js#2896 was fixed in this version of less
works for me, thanks @matthew-dean |
the bootprint-integration-test had failed with [email protected] and it succeeds with 2.7.1. Works for me. Thanks @matthew-dean |
Awesome. Sorry for the broken build everyone, but glad it's working now. Will close this. |
@matthew-dean good job |
Hi, If my project have been compile all less file to css file already with chrun2 program. |
Will put out a hotfix soon if the fix can be confirmed. It looks like PR #2834 introduced a bug that produces a blank source map, and throws an error like:
(Also discussed at #2881.)
Reverting #2834 seems to fix it, but looking for confirmation.
The text was updated successfully, but these errors were encountered: