Suspend should accept IntoFuture instead of Future

[iradicek]

Consider the following:

let res = Resource::new(..., ...);
// let s = Suspend:new(res); // Does not work because `res` is not `Future`
let s = Suspend::new(async move { res.await }); // Works because for await `IntoFuture` is sufficient

Is there any reason for Suspend to not accept impl IntoFuture?

[gbj]

You're probably right. I think it probably wouldn't even be a breaking change, technically, as there is a blanket implementation of IntoFuture for every F: Future.

n.b. Suspend::new(res.into_future()) works here too for now, of course, and is shorter.

[iradicek]

You're right, Suspend::new(res.into_future()) does work.

Yes, anything that takes Future, should work with IntoFuture.

[gbj]

Oh I should add, for the specifics of the example -- Resource itself also implements the rendering traits by doing move || Suspend::new(...), so just as you can use a signal directly in the view, you can do the same with a resource, without explicitly wrapping it in Suspend at all. (For most resources, you want to do some kind of transformation on the data which is why the async move { let res = res.await; /* do something with res */ } syntax is useful)

But point taken, you are correct that the trait bound should probably be IntoFuture.

[gbj]

Done in #3532 as part of 0.8, as it does end up with enough of a change in generic bounds that it's technically breaking.