chore: ignore paralleltest in subtests

leonardobazico · Oct 10, 2024 · b490796 · b490796
1 parent 97f28ab
commit b490796
Show file tree

Hide file tree

Showing 8 changed files with 3 additions and 48 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -32,6 +32,9 @@ linters-settings:
       - standard
       - default
       - prefix(ynabconverter)
+  paralleltest:
+    ignore-missing: false
+    ignore-missing-subtests: true
 
 issues:
   exclude-rules:

diff --git a/internal/file/csv_importer_test.go b/internal/file/csv_importer_test.go
@@ -14,8 +14,6 @@ func TestCsvImporter(t *testing.T) {
 	t.Parallel()
 
 	t.Run("should return error when file does not exist", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		filePath := "examples/does-not-exist.csv"
 		csvReader := file.NewCsvImporterFromFileSytem(utils_test.ExampleFilesFS)
@@ -31,8 +29,6 @@ func TestCsvImporter(t *testing.T) {
 	})
 
 	t.Run("should return error when file exists but is not a csv", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		filePath := "examples/not-a-csv.txt"
 		csvReader := file.NewCsvImporterFromFileSytem(utils_test.ExampleFilesFS)
@@ -44,8 +40,6 @@ func TestCsvImporter(t *testing.T) {
 	})
 
 	t.Run("should not return error when file exists", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		filePath := "examples/cash_app_report.csv"
 		csvReader := file.NewCsvImporterFromFileSytem(utils_test.ExampleFilesFS)
@@ -56,8 +50,6 @@ func TestCsvImporter(t *testing.T) {
 	})
 
 	t.Run("should not return error when file exists and is empty", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		filePath := "examples/empty.csv"
 		csvReader := file.NewCsvImporterFromFileSytem(utils_test.ExampleFilesFS)
@@ -69,8 +61,6 @@ func TestCsvImporter(t *testing.T) {
 	})
 
 	t.Run("should ignore title from records", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		filePath := "examples/just_title.csv"
 		csvReader := file.NewCsvImporterFromFileSytem(utils_test.ExampleFilesFS)
@@ -82,8 +72,6 @@ func TestCsvImporter(t *testing.T) {
 	})
 
 	t.Run("should return matrix of strings when file exists and is not empty", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		filePath := "examples/cash_app_report.csv"
 		csvReader := file.NewCsvImporterFromFileSytem(utils_test.ExampleFilesFS)

diff --git a/internal/file/opener_test.go b/internal/file/opener_test.go
@@ -15,8 +15,6 @@ func TestOpener(t *testing.T) {
 	t.Parallel()
 
 	t.Run("should open file in a given file system", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		filePath := "examples/cash_app_report.csv"
 		opener := file.NewFileSytemOpener(utils_test.ExampleFilesFS)
@@ -29,8 +27,6 @@ func TestOpener(t *testing.T) {
 	})
 
 	t.Run("should open file using os.OpenFile when no file system is given", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		filePath := "opener_test.go"
 		opener := file.NewOsOpener()
@@ -43,8 +39,6 @@ func TestOpener(t *testing.T) {
 	})
 
 	t.Run("should open file given an absolute path", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		testFolder, _ := os.Getwd()
 		filePath := testFolder + "/opener_test.go"
@@ -58,8 +52,6 @@ func TestOpener(t *testing.T) {
 	})
 
 	t.Run("should fail when file does not exist", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		filePath := "does-not-exist.csv"
 		opener := file.NewOsOpener()

diff --git a/pkg/reports/cashapp/report_test.go b/pkg/reports/cashapp/report_test.go
@@ -16,8 +16,6 @@ func TestCashAppReportImporter(t *testing.T) {
 	t.Parallel()
 
 	t.Run("should return error when file does not exist", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		cashAppReport := cashapp.NewCashAppReport(file.NewCsvImporterFromFileSytem(utils_test.ExampleFilesFS))
 		// When
@@ -27,8 +25,6 @@ func TestCashAppReportImporter(t *testing.T) {
 	})
 
 	t.Run("should parse file and get an array of cashapp.Transaction", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		cashAppReport := cashapp.NewCashAppReport(file.NewCsvImporterFromFileSytem(utils_test.ExampleFilesFS))
 		// When
@@ -56,8 +52,6 @@ func TestCashAppReportImporter(t *testing.T) {
 	})
 
 	t.Run("should implement report.ReportImporter interface", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		cashAppReport := cashapp.NewCashAppReport(file.NewCsvImporterFromFileSytem(utils_test.ExampleFilesFS))
 		// When

diff --git a/pkg/reports/cashapp/transaction_test.go b/pkg/reports/cashapp/transaction_test.go
@@ -11,7 +11,6 @@ import (
 	"ynabconverter/pkg/reports/cashapp"
 )
 
-//nolint:paralleltest // t.Setenv isn't compatible with parallel tests
 func TestCashAppTransaction(t *testing.T) {
 	t.Run("should create a cashapp.Transaction from a record", func(t *testing.T) {
 		// Given

diff --git a/pkg/reports/report_test.go b/pkg/reports/report_test.go
@@ -13,8 +13,6 @@ func TestTransaction(t *testing.T) {
 	t.Parallel()
 
 	t.Run("should implement report.Transactioner interface", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		transaction := reports.Transaction{
 			Counterparty: "MTA*NYCT PAYGO",

diff --git a/pkg/reports/ynab/report_test.go b/pkg/reports/ynab/report_test.go
@@ -16,8 +16,6 @@ func TestYnabRecordTransformer(t *testing.T) {
 	t.Parallel()
 
 	t.Run("should implement report.ReportExporter interface", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		ynabRecordTransformer := ynab.NewYnabRecordTransformer()
 		// When
@@ -27,8 +25,6 @@ func TestYnabRecordTransformer(t *testing.T) {
 	})
 
 	t.Run("should return the header", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		ynabRecordTransformer := ynab.NewYnabRecordTransformer()
 		// When
@@ -38,8 +34,6 @@ func TestYnabRecordTransformer(t *testing.T) {
 	})
 
 	t.Run("should return a record", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		ynabRecordTransformer := ynab.NewYnabRecordTransformer()
 		// When
@@ -83,10 +77,7 @@ func TestYnabRecordTransformer(t *testing.T) {
 
 	t.Run("GetRecordsWithHeader", func(t *testing.T) {
 		t.Parallel()
-
 		t.Run("should return records with header as first item", func(t *testing.T) {
-			t.Parallel()
-
 			// Given
 			ynabRecordTransformer := ynab.NewYnabRecordTransformer()
 			// When
@@ -123,8 +114,6 @@ func TestYnabRecordTransformer(t *testing.T) {
 		})
 
 		t.Run("should return an error if the transaction amount is invalid", func(t *testing.T) {
-			t.Parallel()
-
 			// Given
 			ynabRecordTransformer := ynab.NewYnabRecordTransformer()
 			// When

diff --git a/pkg/reports/ynab/transaction_test.go b/pkg/reports/ynab/transaction_test.go
@@ -27,8 +27,6 @@ func TestYnabTransaction(t *testing.T) {
 	// ```
 
 	t.Run("should create a ynab.Transaction from a Transaction", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		transaction := reports.Transaction{
 			Counterparty: "MTA*NYCT PAYGO",
@@ -50,8 +48,6 @@ func TestYnabTransaction(t *testing.T) {
 	})
 
 	t.Run("should create a YnabTransaction from a cashapp.Transaction", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		cashAppTransaction := cashapp.Transaction{
 			TransactionID:        "rmgsrz",
@@ -83,8 +79,6 @@ func TestYnabTransaction(t *testing.T) {
 	})
 
 	t.Run("should fail to create YnabTransaction if transaction.GetDatetime() fails", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		cashAppNotValidDateTransaction := cashapp.Transaction{
 			Date: "not a valid date",
@@ -96,8 +90,6 @@ func TestYnabTransaction(t *testing.T) {
 	})
 
 	t.Run("should fail to create YnabTransaction if transaction.GetAmount() fails", func(t *testing.T) {
-		t.Parallel()
-
 		// Given
 		cashAppNotValidAmountTransaction := cashapp.Transaction{
 			Date:   "2023-10-06 23:59:59 EDT",