tcp: listener: Add bind_device option #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You don't bother me at all! Thanks for making |
lemunozm
requested changes
May 12, 2023
src/adapters/tcp.rs
Outdated
| } | ||
|
|
||
| socket.bind(&addr.into())?; | ||
| socket.listen(1024)?; |
There was a problem hiding this comment.
Where does this magic number come from? Could it be addr.port instead?
There was a problem hiding this comment.
That is the backlog value copied from https://docs.rs/mio/0.8.6/src/mio/net/tcp/listener.rs.html#77 (The maximum number of unaccepted TCP connections.)
There was a problem hiding this comment.
Could you add a comment like this in the code for future readers? 😇
kgraefe
force-pushed
the
tcp-listener-add-bind-device
branch
3 times, most recently
from
eb857ac to
da6586e
Compare
Add option to bind TCP listeners to a specific device, identified by its name. Signed-off-by: Konrad Gräfe <[email protected]>
kgraefe
force-pushed
the
tcp-listener-add-bind-device
branch
from
da6586e to
c7020c5
Compare
lemunozm
reviewed
May 12, 2023
Comment on lines
+33
to
+34
| /// The maximum length of the pending (unaccepted) connection queue of a listener. | ||
| pub const LISTENER_BACKLOG: c_int = 1024; |
lemunozm
approved these changes
May 12, 2023
|
May I ask you to make another release? |
|
Done! it's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to bother you again. It turns out my testing was not sufficient and I need an option to bind the listener to a specific interface as well, when I have multiple interfaces in the same (link-local) subnet. Otherwise the Linux kernel tries to send the
TCP SYN/ACKon whichever interface was present first even when it receivedTCP SYNon the other interface. :-\ Therefore a TCP connection cannot be established.