Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mathieu/analytics/Log events Caregiver create and edit #1605

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Modules/AccountKit/Sources/Database/DatabaseOperations.swift
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@ public class DatabaseOperations {
self.listenerRegistrations.removeAll()
}

public func update(data: some DatabaseDocument, in collection: DatabaseCollection) -> AnyPublisher<Void, Error> {
Future<Void, Error> { promise in
public func update<T: DatabaseDocument>(data: T, in collection: DatabaseCollection) -> AnyPublisher<T, Error> {
Future<T, Error> { promise in
let docRef = self.database.collection(collection.rawValue).document(data.id!)

do {
Expand All @@ -154,7 +154,7 @@ public class DatabaseOperations {
promise(.failure(DatabaseError.customError(error.localizedDescription)))
} else {
log.info("Document \(String(describing: data.id!)) updated successfully in \(collection.rawValue). πŸŽ‰")
promise(.success(()))
promise(.success(data))
}
}
} catch {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import AnalyticsKit
import Combine
import Foundation

public class CaregiverManager {
// MARK: Lifecycle
Expand Down Expand Up @@ -61,8 +62,9 @@ public class CaregiverManager {
.setFailureType(to: Error.self)
.eraseToAnyPublisher()
}
.handleEvents(receiveOutput: { [weak self] _ in
.handleEvents(receiveOutput: { [weak self] newCaregiver in
self?.initializeCaregiversListener()
AnalyticsManager.logEventCaregiverCreate(id: newCaregiver.id!)
})
.eraseToAnyPublisher()
}
Expand All @@ -74,8 +76,12 @@ public class CaregiverManager {
if case let .failure(error) = completion {
self.fetchError.send(error)
}
}, receiveValue: { _ in
// Nothing to do
}, receiveValue: { [weak self] updatedCaregiver in
guard let self else { return }
guard updatedCaregiver.id == self.currentCaregiver.value?.id else { return }
self.setCurrentCaregiver(to: updatedCaregiver)
AnalyticsManager.logEventCaregiverEdit(caregiver: updatedCaregiver.id!)
log.info("Caregiver successfully updated.")
})
.store(in: &self.cancellables)
}
Expand Down Expand Up @@ -107,10 +113,13 @@ public class CaregiverManager {
}

public func setCurrentCaregiver(byID id: String) {
let previousCaregiverID: String? = self.currentCaregiver.value?.id
guard let currentCaregiver = self.caregiverList.value.first(where: { $0.id == id }) else {
return
}
self.currentCaregiver.send(currentCaregiver)

AnalyticsManager.logEventCaregiverSelect(from: previousCaregiverID, to: currentCaregiver.id!)
AnalyticsManager.setDefaultEventParameterCaregiverUid(currentCaregiver.id)
AnalyticsManager.setUserPropertyCaregiverProfessions(values: currentCaregiver.professions)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public class CarereceiverManager {
if case let .failure(error) = completion {
self.fetchError.send(error)
}
}, receiveValue: {
}, receiveValue: { _ in
// Nothing to do
})
.store(in: &self.cancellables)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,22 @@ public extension AnalyticsManager {
logEvent(.caregiverSelect, parameters: params)
}

static func logEventCaregiverCreate(id: String, parameters: [String: Any] = [:]) {
let params: [String: Any] = [
"lk_caregiver_id_new": id,
].merging(parameters) { _, new in new }

logEvent(.caregiverCreate, parameters: params)
}

static func logEventCaregiverEdit(caregiver: String, parameters: [String: Any] = [:]) {
let params: [String: Any] = [
"lk_caregiver_id_edited": caregiver,
].merging(parameters) { _, new in new }

logEvent(.caregiverEdit, parameters: params)
}

static func logEventCarereceiverSkipSelect(parameters: [String: Any] = [:]) {
let params: [String: Any] = [:].merging(parameters) { _, new in new }

Expand Down
8 changes: 8 additions & 0 deletions Modules/AnalyticsKit/Sources/Analytics/AnalyticsManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ public class AnalyticsManager {

case selectContent

case caregiverCreate
case caregiverSelect
case caregiverEdit

case carereceiverSkipSelect

// MARK: Internal
Expand Down Expand Up @@ -81,8 +84,13 @@ public class AnalyticsManager {
case .selectContent:
AnalyticsEventSelectContent // ? "select_content"

case .caregiverCreate:
"caregiver_create"
case .caregiverSelect:
"caregiver_select"
case .caregiverEdit:
"caregiver_edit"

case .carereceiverSkipSelect:
"carereceiver_skip_select"
}
Expand Down
Loading