Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (firmware): Get current OS version - From file #939

Merged
merged 3 commits into from
Sep 12, 2022
Merged

✨ (firmware): Get current OS version - From file #939

merged 3 commits into from
Sep 12, 2022

Conversation

YannLocatelli
Copy link
Member

@YannLocatelli YannLocatelli commented Jul 18, 2022 •
edited
Loading

  • Validated on the robot

@YannLocatelli YannLocatelli added the 01 - type: task Something to do label Jul 18, 2022
@YannLocatelli YannLocatelli added this to the Next Release milestone Jul 18, 2022
@YannLocatelli YannLocatelli requested review from ladislas and HPezz July 18, 2022 15:48
@YannLocatelli YannLocatelli self-assigned this Jul 18, 2022
@YannLocatelli YannLocatelli force-pushed the yann/feature/get-os-version branch from 69f6a98 to 3d6385f Compare July 18, 2022 15:48
@codecov
Copy link

codecov bot commented Jul 18, 2022 •
edited
Loading

Codecov Report

Merging #939 (3f588e3) into develop (f312794) will decrease coverage by 0.45%.
The diff coverage is 91.66%.

❗ Current head 3f588e3 differs from pull request most recent head 0fa6d5f. Consider uploading reports for the commit 0fa6d5f to get more accurate results

@@             Coverage Diff             @@
##           develop     #939      +/-   ##
===========================================
- Coverage    95.98%   95.52%   -0.46%     
===========================================
  Files          131      117      -14     
  Lines         3062     2681     -381     
===========================================
- Hits          2939     2561     -378     
+ Misses         123      120       -3
Impacted Files Coverage Δ
libs/FirmwareKit/include/FirmwareKit.h 100.00% <ø> (ø)
libs/FirmwareKit/source/FirmwareKit.cpp 96.29% <90.90%> (-3.71%) ⬇️
libs/RobotKit/include/RobotController.h 94.25% <100.00%> (-0.25%) ⬇️
libs/RobotKit/include/StateMachine.h 100.00% <0.00%> (ø)
libs/BehaviorKit/source/BehaviorKit.cpp 100.00% <0.00%> (ø)
drivers/CoreTouchSensor/source/CoreTouchSensor.cpp
libs/RFIDKit/include/ISO14443A.h
libs/ActivityKit/include/ActivityKit.h
drivers/CoreQDAC/source/CoreQDAC.cpp
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jul 18, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 181884 (69%) 80260 (30%) 37456 (7%)
os 412348 (26%) 1152324 (73%) 81376 (15%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ❌ 411708 (19%)
412348 (19%)		 📈
640 (0%)		 81376 (15%) ø
bootloader ✔️ ❌ ❌ 181260 (8%)
181884 (8%)		 📈
624 (0%)		 37456 (7%) ø
spike_lk_audio ✔️ ✅ ✅ 132380 (6%) ø 20984 (4%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 195348 (9%) ø 54528 (10%) ø
spike_lk_ble ✔️ ✅ ✅ 233676 (11%) ø 34712 (6%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 92236 (4%) ø 18064 (3%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 152200 (7%) ø 53064 (10%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88352 (4%) ø 20216 (3%) ø
spike_lk_command_kit ✔️ ✅ ✅ 199828 (9%) ø 57864 (11%) ø
spike_lk_config_kit ✔️ ✅ ✅ 136100 (6%) ø 20976 (4%) ø
spike_lk_coreled ✔️ ✅ ✅ 87916 (4%) ø 20104 (3%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84088 (4%) ø 18744 (3%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 143648 (6%) ø 21304 (4%) ø
spike_lk_file_reception ✔️ ✅ ✅ 331036 (15%) ø 34072 (6%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 86712 (4%) ø 18056 (3%) ø
spike_lk_fs ✔️ ✅ ✅ 171024 (8%) ø 47968 (9%) ø
spike_lk_lcd ✔️ ✅ ✅ 177100 (8%) ø 53992 (10%) ø
spike_lk_led_kit ✔️ ✅ ✅ 115708 (5%) ø 21024 (4%) ø
spike_lk_log_kit ✔️ ✅ ✅ 84440 (4%) ø 19248 (3%) ø
spike_lk_motors ✔️ ✅ ✅ 86008 (4%) ø 18088 (3%) ø
spike_lk_qdac ✔️ ✅ ✅ 91508 (4%) ø 18616 (3%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 112188 (5%) ø 21024 (4%) ø
spike_lk_rfid ✔️ ✅ ✅ 84636 (4%) ø 18024 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 87056 (4%) ø 19120 (3%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 83944 (4%) ø 18056 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 84696 (4%) ø 18056 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90336 (4%) ø 18032 (3%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 91608 (4%) ø 18296 (3%) ø
spike_lk_serial_number ✔️ ✅ ✅ 82176 (3%) ø 18336 (3%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 82584 (3%) ø 18072 (3%) ø
spike_lk_update_process_app_base ✔️ ❌ ❌ 144644 (6%)
145284 (6%)		 📈
640 (0%)		 21896 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100328 (4%) ø 19080 (3%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 87940 (4%) ø 19960 (3%) ø
spike_lk_wifi ✔️ ✅ ✅ 130640 (6%) ø 21368 (4%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84112 (4%) ø 18920 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 83424 (3%) ø 18144 (3%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-09-12 10:30:47.415642217 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-09-12 10:30:47.875684211 +0000
@@ -1,48 +1,48 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       560(+560) |     22(+22) |     228(+228) |
+| [fill]                     |       566(+566) |     22(+22) |     228(+228) |
 | [lib]/ActivityKit.a        |       782(+782) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1292(+1292) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1854(+1854) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       588(+588) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7920(+7920) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1308(+1308) |       0(+0) |         0(+0) |
-| [lib]/FirmwareKit.a        |       172(+172) |       0(+0) |         0(+0) |
+| [lib]/FirmwareKit.a        |       754(+754) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/RFIDKit.a            |     1062(+1062) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1470(+1470) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       232(+232) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       638(+638) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   42180(+42180) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 172108(+172108) |   769(+769) | 19735(+19735) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10732(+10732) |     16(+16) |     204(+204) |
-| main.cpp.obj               |   93860(+93860) |   548(+548) | 25826(+25826) |
-| Subtotals                  | 371032(+371032) | 3944(+3944) | 77104(+77104) |
+| main.cpp.obj               |   93848(+93848) |   548(+548) | 25826(+25826) |
+| Subtotals                  | 371608(+371608) | 3944(+3944) | 77104(+77104) |
 Total Static RAM memory (data + bss): 81048(+81048) bytes
-Total Flash memory (text + data): 374976(+374976) bytes
+Total Flash memory (text + data): 375552(+375552) bytes
 
Flash used: 412348&nbsp;(19%) / total: 2097152
SRAM used: 81376&nbsp;(15%) / total: 524288
bootloader (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/bootloader-map.txt	2022-09-12 10:30:48.199713789 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/bootloader-map.txt	2022-09-12 10:30:48.467738255 +0000
@@ -1,28 +1,28 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       236(+236) |       8(+8) |       72(+72) |
+| [fill]                  |       230(+230) |       8(+8) |       72(+72) |
 | [lib]/ConfigKit.a       |       284(+284) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a     |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a       |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a         |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a         |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |       808(+808) |       0(+0) |         0(+0) |
-| [lib]/FirmwareKit.a     |       172(+172) |       0(+0) |         0(+0) |
+| [lib]/FirmwareKit.a     |       754(+754) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a        |     6022(+6022) |     16(+16) | 13816(+13816) |
 | [lib]/c.a               |   42144(+42144) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  |   83390(+83390) |   528(+528) | 11127(+11127) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |   11476(+11476) |     16(+16) |     204(+204) |
 | default_bd.cpp.obj      |       242(+242) |       0(+0) |     568(+568) |
 | main.cpp.obj            |     6870(+6870) |     24(+24) |   8064(+8064) |
 | signing_keys.c.obj      |           0(+0) |       0(+0) |         0(+0) |
-| Subtotals               | 160728(+160728) | 3168(+3168) | 33976(+33976) |
+| Subtotals               | 161304(+161304) | 3168(+3168) | 33976(+33976) |
 Total Static RAM memory (data + bss): 37144(+37144) bytes
-Total Flash memory (text + data): 163896(+163896) bytes
+Total Flash memory (text + data): 164472(+164472) bytes
 
Flash used: 181884&nbsp;(8%) / total: 2097152
SRAM used: 37456&nbsp;(7%) / total: 524288
spike_lk_update_process_app_base (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_update_process_app_base-map.txt	2022-09-12 10:31:03.701137488 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_update_process_app_base-map.txt	2022-09-12 10:31:03.945159863 +0000
@@ -1,22 +1,22 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       218(+218) |       0(+0) |       46(+46) |
+| [fill]                  |       212(+212) |       0(+0) |       46(+46) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |       812(+812) |       0(+0) |         0(+0) |
-| [lib]/FirmwareKit.a     |       172(+172) |       0(+0) |         0(+0) |
+| [lib]/FirmwareKit.a     |       754(+754) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a        |     1282(+1282) |     12(+12) |     132(+132) |
 | [lib]/c.a               |   41120(+41120) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  |   69234(+69234) |   524(+524) | 10473(+10473) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     5424(+5424) |       8(+8) |       44(+44) |
 | main.cpp.obj            |     3354(+3354) |       0(+0) |   7660(+7660) |
-| Subtotals               | 130152(+130152) | 3120(+3120) | 18480(+18480) |
+| Subtotals               | 130728(+130728) | 3120(+3120) | 18480(+18480) |
 Total Static RAM memory (data + bss): 21600(+21600) bytes
-Total Flash memory (text + data): 133272(+133272) bytes
+Total Flash memory (text + data): 133848(+133848) bytes
 
Flash used: 145284&nbsp;(6%) / total: 2097152
SRAM used: 21896&nbsp;(4%) / total: 524288

@github-actions
Copy link

github-actions bot commented Jul 18, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 169444 (64%) 92700 (35%) 30920 (5%)
os 374256 (23%) 1190416 (76%) 74448 (14%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ❌ 373616 (17%)
374256 (17%)		 📈
640 (0%)		 74448 (14%) ø
bootloader ✔️ ❌ ❌ 168820 (8%)
169444 (8%)		 📈
624 (0%)		 30920 (5%) ø
spike_lk_audio ✔️ ✅ ✅ 122324 (5%) ø 14568 (2%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 186848 (8%) ø 48112 (9%) ø
spike_lk_ble ✔️ ✅ ✅ 225792 (10%) ø 28056 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 82948 (3%) ø 11544 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 144632 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65712 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ ✅ ✅ 189632 (9%) ø 50936 (9%) ø
spike_lk_config_kit ✔️ ✅ ✅ 124188 (5%) ø 14312 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 128680 (6%) ø 14384 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 326968 (15%) ø 27576 (5%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_fs ✔️ ✅ ✅ 171728 (8%) ø 47880 (9%) ø
spike_lk_lcd ✔️ ✅ ✅ 167468 (7%) ø 47320 (9%) ø
spike_lk_led_kit ✔️ ✅ ✅ 103992 (4%) ø 14608 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 63736 (3%) ø 12256 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62600 (2%) ø 11488 (2%) ø
spike_lk_qdac ✔️ ✅ ✅ 78564 (3%) ø 11816 (2%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 103480 (4%) ø 14608 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 80920 (3%) ø 11520 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 67048 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ ✅ ✅ 58904 (2%) ø 11480 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ❌ ❌ 122804 (5%)
123476 (5%)		 📈
672 (0%)		 15288 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 82032 (3%) ø 13288 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-09-12 10:30:56.579848389 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-09-12 10:30:56.955853519 +0000
@@ -1,48 +1,48 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       574(+574) |     22(+22) |     207(+207) |
+| [fill]                     |       580(+580) |     22(+22) |     207(+207) |
 | [lib]/ActivityKit.a        |       782(+782) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1292(+1292) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1854(+1854) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       588(+588) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7920(+7920) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1308(+1308) |       0(+0) |         0(+0) |
-| [lib]/FirmwareKit.a        |       172(+172) |       0(+0) |         0(+0) |
+| [lib]/FirmwareKit.a        |       754(+754) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/RFIDKit.a            |     1062(+1062) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1470(+1470) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       232(+232) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       638(+638) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   43284(+43284) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 170856(+170856) |   769(+769) | 19647(+19647) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10684(+10684) |     16(+16) |     204(+204) |
-| main.cpp.obj               |   56410(+56410) |   548(+548) | 19007(+19007) |
-| Subtotals                  | 333400(+333400) | 3944(+3944) | 70176(+70176) |
+| main.cpp.obj               |   56398(+56398) |   548(+548) | 19007(+19007) |
+| Subtotals                  | 333976(+333976) | 3944(+3944) | 70176(+70176) |
 Total Static RAM memory (data + bss): 74120(+74120) bytes
-Total Flash memory (text + data): 337344(+337344) bytes
+Total Flash memory (text + data): 337920(+337920) bytes
 
Flash used: 374256&nbsp;(17%) / total: 2097152
SRAM used: 74448&nbsp;(14%) / total: 524288
bootloader (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/bootloader-map.txt	2022-09-12 10:30:57.223857431 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/bootloader-map.txt	2022-09-12 10:30:57.443860642 +0000
@@ -1,26 +1,26 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       180(+180) |       8(+8) |       69(+69) |
+| [fill]                  |       174(+174) |       8(+8) |       69(+69) |
 | [lib]/ConfigKit.a       |       284(+284) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a     |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a       |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a         |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a         |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |       808(+808) |       0(+0) |         0(+0) |
-| [lib]/FirmwareKit.a     |       172(+172) |       0(+0) |         0(+0) |
+| [lib]/FirmwareKit.a     |       754(+754) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a        |     6022(+6022) |     16(+16) | 13816(+13816) |
 | [lib]/c.a               |   43360(+43360) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  |   74818(+74818) |   528(+528) | 11003(+11003) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |   10968(+10968) |     16(+16) |     204(+204) |
 | default_bd.cpp.obj      |       242(+242) |       0(+0) |     568(+568) |
 | main.cpp.obj            |     4454(+4454) |     24(+24) |   1655(+1655) |
 | signing_keys.c.obj      |           0(+0) |       0(+0) |         0(+0) |
-| Subtotals               | 150024(+150024) | 3168(+3168) | 27440(+27440) |
+| Subtotals               | 150600(+150600) | 3168(+3168) | 27440(+27440) |
 Total Static RAM memory (data + bss): 30608(+30608) bytes
-Total Flash memory (text + data): 153192(+153192) bytes
+Total Flash memory (text + data): 153768(+153768) bytes
 
Flash used: 169444&nbsp;(8%) / total: 2097152
SRAM used: 30920&nbsp;(5%) / total: 524288
spike_lk_update_process_app_base (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_update_process_app_base-map.txt	2022-09-12 10:31:09.764039559 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_update_process_app_base-map.txt	2022-09-12 10:31:09.956042326 +0000
@@ -1,20 +1,20 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       158(+158) |       0(+0) |       38(+38) |
+| [fill]                  |       188(+188) |       0(+0) |       38(+38) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |       812(+812) |       0(+0) |         0(+0) |
-| [lib]/FirmwareKit.a     |       172(+172) |       0(+0) |         0(+0) |
+| [lib]/FirmwareKit.a     |       754(+754) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a        |     1282(+1282) |     12(+12) |     132(+132) |
 | [lib]/c.a               |   42336(+42336) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     3276(+3276) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  |   61310(+61310) |   524(+524) | 10341(+10341) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |           0(+0) |       0(+0) |         0(+0) |
 | main.cpp.obj            |     1014(+1014) |       0(+0) |   1252(+1252) |
-| Subtotals               | 111380(+111380) | 3112(+3112) | 11888(+11888) |
+| Subtotals               | 111992(+111992) | 3112(+3112) | 11888(+11888) |
 Total Static RAM memory (data + bss): 15000(+15000) bytes
-Total Flash memory (text + data): 114492(+114492) bytes
+Total Flash memory (text + data): 115104(+115104) bytes
 
Flash used: 123476&nbsp;(5%) / total: 2097152
SRAM used: 15288&nbsp;(2%) / total: 524288

@YannLocatelli YannLocatelli force-pushed the yann/feature/get-os-version branch 2 times, most recently from bf1d0c8 to fdaaa42 Compare July 20, 2022 17:58
@YannLocatelli YannLocatelli linked an issue Jul 22, 2022 that may be closed by this pull request
Get OS version from SD #819
Closed
HPezz
HPezz reviewed Jul 25, 2022
View reviewed changes
Copy link
Contributor

@HPezz HPezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM même remarque que pour la date_of_test, si possibilité de ne pas adapetr al fct pour le test c'est mieux

@YannLocatelli YannLocatelli force-pushed the yann/feature/get-os-version branch from 3f588e3 to 05766b6 Compare July 27, 2022 10:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 27, 2022 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@YannLocatelli YannLocatelli requested a review from HPezz July 27, 2022 10:21
@ladislas ladislas force-pushed the yann/feature/get-os-version branch from 05766b6 to 3551a77 Compare September 8, 2022 13:37
@ladislas ladislas force-pushed the yann/feature/get-os-version branch from 3551a77 to 0fa6d5f Compare September 12, 2022 10:19
@ladislas ladislas merged commit 29d760b into develop Sep 12, 2022
@ladislas ladislas deleted the yann/feature/get-os-version branch September 12, 2022 10:21
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

85.7% 85.7% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladislas ladislas Awaiting requested review from ladislas

@HPezz HPezz Awaiting requested review from HPezz

Assignees

@YannLocatelli YannLocatelli

Labels
01 - type: task Something to do
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Get OS version from SD
3 participants
@YannLocatelli @HPezz @ladislas