Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BufferedSerial mock #243

Merged
merged 3 commits into from
May 19, 2021
Merged

BufferedSerial mock #243

merged 3 commits into from
May 19, 2021

Conversation

Kabroc
Copy link
Contributor

@Kabroc Kabroc commented May 5, 2021

No description provided.

@Kabroc Kabroc added the 01 - type: task Something to do label May 5, 2021
@Kabroc Kabroc requested review from ladislas and YannLocatelli May 5, 2021 15:35
@Kabroc Kabroc self-assigned this May 5, 2021
@codecov
Copy link

codecov bot commented May 5, 2021 •
edited
Loading

Codecov Report

Merging #243 (4efb428) into develop (d53a8a2) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 4efb428 differs from pull request most recent head 99dd7af. Consider uploading reports for the commit 99dd7af to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #243   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           52        53    +1     
  Lines          928       932    +4     
=========================================
+ Hits           928       932    +4
Impacted Files Coverage Δ
...rs/CoreBufferedSerial/include/CoreBufferedSerial.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d53a8a2...99dd7af. Read the comment docs.

@Kabroc Kabroc force-pushed the benjamin/feature/mock_buffered_serial branch from 4f89804 to c164d8c Compare May 18, 2021 12:16
ladislas
ladislas requested changes May 18, 2021
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ça m'a l'air pas mal, quelques changements avant de merge.

tests/unit/mbed-os/stubs/stub_BufferedSerial.cpp Show resolved Hide resolved
tests/unit/mocks/mock_CoreBufferedSerial.h Outdated Show resolved Hide resolved
tests/unit/mbed-os/stubs/stub_BufferedSerial.cpp Outdated Show resolved Hide resolved
drivers/CoreBufferedSerial/include/CoreBufferedSerial.h Outdated Show resolved Hide resolved
drivers/CoreBufferedSerial/include/CoreBufferedSerial.h Outdated Show resolved Hide resolved
drivers/CoreBufferedSerial/include/CoreBufferedSerial.h Outdated Show resolved Hide resolved
drivers/CoreBufferedSerial/include/CoreBufferedSerial.h Outdated Show resolved Hide resolved
drivers/CoreBufferedSerial/include/CoreBufferedSerial.h Show resolved Hide resolved
drivers/CoreBufferedSerial/source/CoreBufferedSerial.cpp Show resolved Hide resolved
drivers/CoreBufferedSerial/source/CoreBufferedSerial.cpp Show resolved Hide resolved
YannLocatelli
YannLocatelli approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@YannLocatelli YannLocatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo le CMakeLists de tests, c'est bon pour moi

tests/unit/mbed-os/CMakeLists.txt Outdated Show resolved Hide resolved
@Kabroc Kabroc force-pushed the benjamin/feature/mock_buffered_serial branch from 00af8f2 to c9505b6 Compare May 19, 2021 10:00
@ladislas ladislas force-pushed the benjamin/feature/mock_buffered_serial branch 2 times, most recently from 53c08bd to 79d593e Compare May 19, 2021 15:02
@Kabroc Kabroc force-pushed the benjamin/feature/mock_buffered_serial branch 5 times, most recently from f0f51ec to 4efb428 Compare May 19, 2021 15:53
@Kabroc Kabroc force-pushed the benjamin/feature/mock_buffered_serial branch from 4efb428 to 99dd7af Compare May 19, 2021 15:59
@codeclimate
Copy link

codeclimate bot commented May 19, 2021

Code Climate has analyzed commit 99dd7af and detected 0 issues on this pull request.

View more on Code Climate.

@ladislas ladislas merged commit af3f455 into develop May 19, 2021
@ladislas ladislas deleted the benjamin/feature/mock_buffered_serial branch May 19, 2021 16:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladislas ladislas ladislas requested changes

@YannLocatelli YannLocatelli YannLocatelli approved these changes

Assignees

@Kabroc Kabroc

Labels
01 - type: task Something to do
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kabroc @ladislas @YannLocatelli