Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(logger): Better function info #241

Merged
merged 1 commit into from
May 5, 2021

Conversation

ladislas
Copy link
Member

@ladislas ladislas commented May 5, 2021

Previously we used PRETTY_FUNCTION which outputs too many
details with the function signature

Previously we used __PRETTY_FUNCTION__ which outputs too many
details with the function signature
@ladislas ladislas requested a review from YannLocatelli May 5, 2021 14:07
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #241 (d05733d) into develop (f660b3d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #241   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines          811       811           
=========================================
  Hits           811       811           
Impacted Files Coverage Δ
libs/LogKit/include/LogKit.h 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f660b3d...d05733d. Read the comment docs.

@ladislas ladislas force-pushed the ladislas/feature/logger-better-function-name branch 2 times, most recently from 7873774 to d05733d Compare May 5, 2021 14:17
@codeclimate
Copy link

codeclimate bot commented May 5, 2021

Code Climate has analyzed commit d05733d and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ladislas ladislas merged commit fff3597 into develop May 5, 2021
@ladislas ladislas deleted the ladislas/feature/logger-better-function-name branch May 5, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants