WIP - (clang-tidy): Modernize code using clang-tidy #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladislas
force-pushed
the
ladislas/feature/clang-tidy-modernize
branch
from
34a8ccf to
b2b2812
Compare
Codecov Report
@@ Coverage Diff @@
## develop #227 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 874 874
=========================================
Hits 874 874 Continue to review full report at Codecov.
|
ladislas
force-pushed
the
ladislas/feature/clang-tidy-modernize
branch
from
b2b2812 to
2b5ecb8
Compare
ladislas
force-pushed
the
ladislas/feature/clang-tidy-modernize
branch
from
2b5ecb8 to
066f414
Compare
ladislas
force-pushed
the
ladislas/feature/clang-tidy-modernize
branch
from
066f414 to
f99b999
Compare
|
Code Climate has analyzed commit f99b999 and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed! |
ladislas
force-pushed
the
ladislas/feature/clang-tidy-modernize
branch
18 times, most recently
from
7cc15f2 to
e0e1dd3
Compare
ladislas
force-pushed
the
ladislas/feature/clang-tidy-modernize
branch
from
e0e1dd3 to
4f6425e
Compare
YannLocatelli
approved these changes
Jul 5, 2021
ladislas
force-pushed
the
ladislas/feature/clang-tidy-modernize
branch
from
4f6425e to
e8f43cb
Compare
When running clang-tidy from the command line, it was not able to find
std headers such as chrono, cstddef, etc.
This is because the compile database did not have all the include path
known to the compiler (arm-none-eabi-g{cc,++}) and therefore clang-tidy
was falling back to clang's own includes
Fix from: https://gitlab.kitware.com/cmake/cmake/-/issues/20912#note_795673
The target can be used to run clang-tidy on changed .h and .cpp files in the current branch
Add: - 10, 100, 1000 - hours/minutes - 60, 3600 - baudrates - 9600, 115200
In particular, the following rules were breaking LogKit because of macros: - cppcoreguidelines-pro-bounds-array-to-pointer-decay - cppcoreguidelines-pro-bounds-pointer-arithmetic - cppcoreguidelines-pro-type-vararg We should find a way to fix this and still use the rules.
ladislas
force-pushed
the
ladislas/feature/clang-tidy-modernize
branch
from
e8f43cb to
e8702a8
Compare
ladislas
force-pushed
the
ladislas/feature/clang-tidy-modernize
branch
from
9011349 to
7f4b8d3
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #226, this PR is a wip showing how clang-tidy can improve code readability and good practices