Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ (MotionKit): Remove log_debug in UTs of RotationControl #1321

Merged
merged 1 commit into from
Mar 13, 2023
Merged

✅ (MotionKit): Remove log_debug in UTs of RotationControl #1321

merged 1 commit into from
Mar 13, 2023

Conversation

YannLocatelli
Copy link
Member

No description provided.

@YannLocatelli YannLocatelli added the 01 - type: task Something to do label Mar 10, 2023
@YannLocatelli YannLocatelli added this to the Future Release milestone Mar 10, 2023
@YannLocatelli YannLocatelli self-assigned this Mar 10, 2023
@github-actions
Copy link

github-actions bot commented Mar 10, 2023 •
edited
Loading

🔖 Version comparison

Version Same as filename Same as os_version
os 1.3.0+1678699654 ✔️ ✔️
firmware
(bootloader + os)		 1.3.0+1678699654 ✔️ ✔️

@github-actions
Copy link

📈 Changes Impact Analysis Report

📌 Info

  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • enable_log_debug: OFF
base head
branch develop yann/clean/ut/remove_logs
sha 2870ac8 236b935
mbed mbed-os@master+fixes+gcc-11-support mbed-os@master+fixes+gcc-11-support
-std -std=c++20 -std=c++20

🤖 Firmware impact analysis

Target Flash Used (base/head) Flash Used Δ Flash Available (base/head) Static RAM (base/head) Static RAM Δ
bootloader 170888 (65%) ø 91256 (34%)
91256 (34%)		 30960 (5%) ø
os 446056 (28%) ø 1118616 (71%)
1118616 (71%)		 83648 (15%) ø
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

🔬 Detailed impact analysis

Click to show detailed analysis for all targets
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 446056 (21%) ø 83648 (15%) ø
bootloader ✔️ ✅ ✅ 170888 (8%) ø 30960 (5%) ø
functional_ut_boost_ut ✔️ ✅ ✅ 394140 (18%) ø 20456 (3%) ø
functional_ut_core_imu ✔️ ✅ ✅ 377656 (18%) ø 20968 (3%) ø
functional_ut_deep_sleep_core_buffered_serial ✔️ ✅ ✅ 360600 (17%) ø 20440 (3%) ø
functional_ut_deep_sleep_core_motor ✔️ ✅ ✅ 364540 (17%) ø 20480 (3%) ø
functional_ut_deep_sleep_core_pwm ✔️ ✅ ✅ 366676 (17%) ø 20480 (3%) ø
functional_ut_deep_sleep_log_kit ✔️ ✅ ✅ 352568 (16%) ø 20408 (3%) ø
functional_ut_deep_sleep_mbed_hal ✔️ ✅ ✅ 354344 (16%) ø 20408 (3%) ø
functional_ut_file_manager ✔️ ✅ ✅ 376272 (17%) ø 20696 (3%) ø
functional_ut_firmware_kit ✔️ ✅ ✅ 367084 (17%) ø 20688 (3%) ø
functional_ut_imu_kit ✔️ ✅ ✅ 381572 (18%) ø 21144 (4%) ø
functional_ut_io_expander ✔️ ✅ ✅ 359576 (17%) ø 20424 (3%) ø
functional_ut_qdac ✔️ ✅ ✅ 360744 (17%) ø 20424 (3%) ø
spike_lk_audio ✔️ ✅ ✅ 127092 (6%) ø 14592 (2%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 189440 (9%) ø 48096 (9%) ø
spike_lk_ble ✔️ ✅ ✅ 229600 (10%) ø 28472 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 82948 (3%) ø 11544 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 145976 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65840 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ ✅ ✅ 220712 (10%) ø 52640 (10%) ø
spike_lk_config_kit ✔️ ✅ ✅ 127324 (6%) ø 14360 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 76292 (3%) ø 13688 (2%) ø
spike_lk_core_touch_sensor ✔️ ✅ ✅ 80508 (3%) ø 12248 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74800 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 139528 (6%) ø 14440 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 336000 (16%) ø 27792 (5%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_fs ✔️ ✅ ✅ 175668 (8%) ø 47928 (9%) ø
spike_lk_imu_kit ✔️ ✅ ✅ 98860 (4%) ø 13032 (2%) ø
spike_lk_lcd ✔️ ✅ ✅ 163352 (7%) ø 46680 (8%) ø
spike_lk_led_kit ✔️ ✅ ✅ 103424 (4%) ø 14528 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 63288 (3%) ø 12256 (2%) ø
spike_lk_motion_kit ✔️ ✅ ✅ 111204 (5%) ø 15168 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62864 (2%) ø 11488 (2%) ø
spike_lk_qdac ✔️ ✅ ✅ 78852 (3%) ø 11808 (2%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 217944 (10%) ø 49824 (9%) ø
spike_lk_rfid ✔️ ✅ ✅ 79084 (3%) ø 11504 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 78388 (3%) ø 12600 (2%) ø
spike_lk_sensors_imu_lsm6dsox ✔️ ✅ ✅ 89468 (4%) ø 12824 (2%) ø
spike_lk_sensors_imu_lsm6dsox_fusion_calibration ✔️ ✅ ✅ 97916 (4%) ø 12952 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 67272 (3%) ø 11424 (2%) ø
spike_lk_serial_number ✔️ ✅ ✅ 133084 (6%) ø 14304 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_touch_sensor_kit ✔️ ✅ ✅ 87896 (4%) ø 12824 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 145620 (6%) ø 15576 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 80196 (3%) ø 13288 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116544 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 58032 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

No differenes where found in map files.

@github-actions
Copy link

📈 Changes Impact Analysis Report

📌 Info

  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • enable_log_debug: ON
base head
branch develop yann/clean/ut/remove_logs
sha 2870ac8 236b935
mbed mbed-os@master+fixes+gcc-11-support mbed-os@master+fixes+gcc-11-support
-std -std=c++20 -std=c++20

🤖 Firmware impact analysis

Target Flash Used (base/head) Flash Used Δ Flash Available (base/head) Static RAM (base/head) Static RAM Δ
bootloader 183692 (70%) ø 78452 (29%)
78452 (29%)		 41664 (7%) ø
os 507612 (32%) ø 1057060 (67%)
1057060 (67%)		 94872 (18%) ø
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

🔬 Detailed impact analysis

Click to show detailed analysis for all targets
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 507612 (24%) ø 94872 (18%) ø
bootloader ✔️ ✅ ✅ 183692 (8%) ø 41664 (7%) ø
functional_ut_boost_ut ✔️ ✅ ✅ 409276 (19%) ø 30608 (5%) ø
functional_ut_core_imu ✔️ ✅ ✅ 385140 (18%) ø 31120 (5%) ø
functional_ut_deep_sleep_core_buffered_serial ✔️ ✅ ✅ 368332 (17%) ø 30560 (5%) ø
functional_ut_deep_sleep_core_motor ✔️ ✅ ✅ 376140 (17%) ø 30632 (5%) ø
functional_ut_deep_sleep_core_pwm ✔️ ✅ ✅ 378356 (18%) ø 30632 (5%) ø
functional_ut_deep_sleep_log_kit ✔️ ✅ ✅ 365268 (17%) ø 30976 (5%) ø
functional_ut_deep_sleep_mbed_hal ✔️ ✅ ✅ 366712 (17%) ø 30560 (5%) ø
functional_ut_file_manager ✔️ ✅ ✅ 388092 (18%) ø 30856 (5%) ø
functional_ut_firmware_kit ✔️ ✅ ✅ 379116 (18%) ø 30848 (5%) ø
functional_ut_imu_kit ✔️ ✅ ✅ 389120 (18%) ø 31296 (5%) ø
functional_ut_io_expander ✔️ ✅ ✅ 371176 (17%) ø 30576 (5%) ø
functional_ut_qdac ✔️ ✅ ✅ 372344 (17%) ø 30576 (5%) ø
spike_lk_audio ✔️ ✅ ✅ 137724 (6%) ø 25168 (4%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 198500 (9%) ø 58672 (11%) ø
spike_lk_ble ✔️ ✅ ✅ 237980 (11%) ø 39416 (7%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 92364 (4%) ø 22224 (4%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 153672 (7%) ø 57224 (10%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88544 (4%) ø 24376 (4%) ø
spike_lk_command_kit ✔️ ✅ ✅ 230068 (10%) ø 63728 (12%) ø
spike_lk_config_kit ✔️ ✅ ✅ 139780 (6%) ø 25184 (4%) ø
spike_lk_coreled ✔️ ✅ ✅ 88108 (4%) ø 24264 (4%) ø
spike_lk_core_touch_sensor ✔️ ✅ ✅ 93164 (4%) ø 22824 (4%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84152 (4%) ø 22904 (4%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 154560 (7%) ø 25520 (4%) ø
spike_lk_file_reception ✔️ ✅ ✅ 339964 (16%) ø 38448 (7%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 86776 (4%) ø 22216 (4%) ø
spike_lk_fs ✔️ ✅ ✅ 178228 (8%) ø 57536 (10%) ø
spike_lk_imu_kit ✔️ ✅ ✅ 107504 (5%) ø 23744 (4%) ø
spike_lk_lcd ✔️ ✅ ✅ 173500 (8%) ø 57520 (10%) ø
spike_lk_led_kit ✔️ ✅ ✅ 115204 (5%) ø 25104 (4%) ø
spike_lk_log_kit ✔️ ✅ ✅ 84776 (4%) ø 23408 (4%) ø
spike_lk_motion_kit ✔️ ✅ ✅ 116240 (5%) ø 25712 (4%) ø
spike_lk_motors ✔️ ✅ ✅ 86336 (4%) ø 22248 (4%) ø
spike_lk_qdac ✔️ ✅ ✅ 91796 (4%) ø 22768 (4%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 225588 (10%) ø 60400 (11%) ø
spike_lk_rfid ✔️ ✅ ✅ 84216 (4%) ø 22184 (4%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 87376 (4%) ø 23312 (4%) ø
spike_lk_sensors_imu_lsm6dsox ✔️ ✅ ✅ 98624 (4%) ø 23536 (4%) ø
spike_lk_sensors_imu_lsm6dsox_fusion_calibration ✔️ ✅ ✅ 105064 (5%) ø 23104 (4%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 84072 (4%) ø 22216 (4%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 84824 (4%) ø 22216 (4%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90616 (4%) ø 22192 (4%) ø
spike_lk_serial_number ✔️ ✅ ✅ 145028 (6%) ø 25256 (4%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 82712 (3%) ø 22232 (4%) ø
spike_lk_touch_sensor_kit ✔️ ✅ ✅ 96668 (4%) ø 23392 (4%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 157932 (7%) ø 26288 (5%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100456 (4%) ø 23240 (4%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 87520 (4%) ø 24136 (4%) ø
spike_lk_wifi ✔️ ✅ ✅ 130984 (6%) ø 25528 (4%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84176 (4%) ø 23080 (4%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 83488 (3%) ø 22304 (4%) ø

🗺️ Map files diff output

No differenes where found in map files.

@codecov
Copy link

codecov bot commented Mar 10, 2023 •
edited
Loading

Codecov Report

Merging #1321 (236b935) into develop (2870ac8) will not change coverage.
The diff coverage is n/a.

❗ Current head 236b935 differs from pull request most recent head a719b98. Consider uploading reports for the commit a719b98 to get more accurate results

@@           Coverage Diff            @@
##           develop    #1321   +/-   ##
========================================
  Coverage    98.73%   98.73%           
========================================
  Files          145      145           
  Lines         3727     3727           
========================================
  Hits          3680     3680           
  Misses          47       47

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ladislas ladislas force-pushed the yann/clean/ut/remove_logs branch from 236b935 to a719b98 Compare March 13, 2023 09:08
@ladislas ladislas force-pushed the yann/clean/ut/remove_logs branch from a719b98 to 38a4d36 Compare March 13, 2023 09:17
@ladislas ladislas merged commit 5a0ef08 into develop Mar 13, 2023
@ladislas ladislas deleted the yann/clean/ut/remove_logs branch March 13, 2023 09:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@YannLocatelli YannLocatelli

Labels
01 - type: task Something to do
Projects
None yet
Milestone
Future Release
Development

Successfully merging this pull request may close these issues.
2 participants
@YannLocatelli @ladislas