-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hugo/feature/Get imu data on interrupt #1257
Conversation
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
715500e
to
69699b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First review, good work! 👍
69699b1
to
334942f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1257 +/- ##
===========================================
+ Coverage 98.59% 98.65% +0.05%
===========================================
Files 151 147 -4
Lines 3781 3790 +9
===========================================
+ Hits 3728 3739 +11
+ Misses 53 51 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
f5043c9
to
a5c9545
Compare
50f6506
to
6b4a6a7
Compare
1fe679f
to
4d66378
Compare
6b4a6a7
to
474113d
Compare
4d66378
to
28def88
Compare
12e7fec
to
f5fb58a
Compare
28def88
to
bb417c4
Compare
f5fb58a
to
34d3f2a
Compare
Version comparison
|
34d3f2a
to
635e4e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo a few suggestions 👍
it's also a bit dense and hard to read, especially the tests, where we don't know if the changes are real fixes or temporary fixes.
I would prefer we turn off the tests not directly related to the PR completely while we wait for a more stable state of the code.
848c8d5
to
daa3cbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot help on refactor, I don't have much knowledge on constrains and features implemented inside CoreIMU/IMUKit.
On topic of Interrupt implementation, I am fine with it.
daa3cbb
to
82b9dc1
Compare
5879f40
to
c929bf3
Compare
c929bf3
to
ce73e19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
As we are also returning dps, it makes more sense to return g instead of mg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d0b4201
to
db08b03
Compare
Kudos, SonarCloud Quality Gate passed! |
Refactoring of CoreLSM6DSOX : _ Use interrupt to compute imu data as soon as gyroscope data are received.