✨ (file): Add clear file #1197
Merged
✨ (file): Add clear file #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
Codecov Report
@@ Coverage Diff @@
## develop #1197 +/- ##
========================================
Coverage 96.16% 96.16%
========================================
Files 146 146
Lines 3542 3548 +6
========================================
+ Hits 3406 3412 +6
Misses 136 136
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
HPezz
approved these changes
Dec 9, 2022
YannLocatelli
force-pushed
the
yann/feature/add-clear-file
branch
from
1b92c1a to
34ac265
Compare
ladislas
requested changes
Dec 12, 2022
There was a problem hiding this comment.
the File part LGTM w/ small suggestions 👍
regarding the FileManager part, I would prefer we keep it out of this PR as it's using exists which will suffer from the same issues we previously had.
the FileManager test part is also a bit strange, I'm not sure I understand why you are testing like this.
Comment on lines
89
to
97
| auto initial_file_size = std::filesystem::file_size(path_A); | ||
| auto initial_free_space = std::filesystem::space(path_A).free; | ||
|
|
||
| EXPECT_NE(initial_file_size, 0); | ||
|
|
||
| FileManagerKit::clear(path_A); | ||
|
|
||
| auto final_file_size = std::filesystem::file_size(path_A); | ||
| auto final_free_space = std::filesystem::space(path_A).free; |
There was a problem hiding this comment.
I'm not sure I understand why you want to test it like this.
why not just write to the file, measure the size, clear it, measure again?
There was a problem hiding this comment.
It's to verify that it is not just a truncation of a file: move the EOF character to the beginning of file and keep the previous data allocated but inaccessible.
YannLocatelli
force-pushed
the
yann/feature/add-clear-file
branch
from
34ac265 to
e71df79
Compare
YannLocatelli
changed the title
Delete file content but file still exists
YannLocatelli
force-pushed
the
yann/feature/add-clear-file
branch
from
8598fd7 to
0f113b7
Compare
|
Kudos, SonarCloud Quality Gate passed! |
ladislas
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.