✨ (MotionKit): Add on_rotation_ended_callback to rotate function #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
Codecov Report
@@ Coverage Diff @@
## develop #1193 +/- ##
========================================
Coverage 96.10% 96.10%
========================================
Files 146 146
Lines 3544 3545 +1
========================================
+ Hits 3406 3407 +1
Misses 138 138
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ladislas
approved these changes
Dec 8, 2022
spikes/lk_motion_kit/main.cpp
Outdated
| @@ -96,7 +96,7 @@ void onMagicCardAvailable(const MagicCard &card) | |||
| { | |||
| switch (card.getId()) { | |||
| case (MagicCard::number_1.getId()): | |||
| motionkit.rotate(1, Rotation::counterClockwise); | |||
| motionkit.rotate(1, Rotation::counterClockwise, [&] { log_debug("Callback end of rotation"); }); | |||
There was a problem hiding this comment.
no need for &
Suggested change
| motionkit.rotate(1, Rotation::counterClockwise, [&] { log_debug("Callback end of rotation"); }); | |
| motionkit.rotate(1, Rotation::counterClockwise, [] { log_debug("Callback end of rotation"); }); |
HPezz
force-pushed
the
hugo/feature/Add-onRotationDidEndCallback-to-MotionKit
branch
from
4abb309 to
d6e0201
Compare
ladislas
force-pushed
the
hugo/feature/Add-onRotationDidEndCallback-to-MotionKit
branch
from
d6e0201 to
05bded9
Compare
ladislas
deleted the
hugo/feature/Add-onRotationDidEndCallback-to-MotionKit
branch
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.