Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ladislas/bugfix/ut corejpeg missing include #1151

Merged
merged 3 commits into from
Nov 23, 2022
Merged

ladislas/bugfix/ut corejpeg missing include #1151

merged 3 commits into from
Nov 23, 2022

Conversation

ladislas
Copy link
Member

@ladislas ladislas commented Nov 22, 2022 •
edited
Loading

Fix issue spotted at:

drivers/CoreVideo/CMakeFiles/CoreVideo.dir/source/CoreJPEG.cpp.o -c /home/runner/work/LekaOS/LekaOS/drivers/CoreVideo/source/CoreJPEG.cpp
/home/runner/work/LekaOS/LekaOS/drivers/CoreVideo/source/CoreJPEG.cpp:93:30: error: no member named 'adjacent_find' in namespace 'std'
                auto *find_index           = std::adjacent_find(std::begin(buffer), buffer_end_index, is_jpeg_soi_marker_predicate);
                                             ~~~~~^
1 error generated.

@codecov
Copy link

codecov bot commented Nov 22, 2022 •
edited
Loading

Codecov Report

Merging #1151 (aa7386b) into develop (0d15622) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1151   +/-   ##
========================================
  Coverage    96.00%   96.00%           
========================================
  Files          138      138           
  Lines         3253     3253           
========================================
  Hits          3123     3123           
  Misses         130      130
Impacted Files Coverage Δ
drivers/CoreVideo/include/CoreJPEG.hpp 100.00% <ø> (ø)
drivers/CoreVideo/source/CoreJPEG.cpp 92.72% <ø> (ø)
libs/BLEKit/include/AdvertisingData.h 100.00% <ø> (ø)
libs/BLEKit/include/BLEKit.h 100.00% <ø> (ø)
libs/BLEKit/include/BLEServiceBattery.h 100.00% <ø> (ø)
libs/BLEKit/include/BLEServiceCommands.h 33.33% <ø> (ø)
libs/BLEKit/include/BLEServiceDeviceInformation.h 100.00% <ø> (ø)
libs/BLEKit/include/BLEServiceFileExchange.h 100.00% <ø> (ø)
libs/BLEKit/include/BLEServiceMonitoring.h 100.00% <ø> (ø)
libs/BLEKit/include/BLEServiceUpdate.h 100.00% <ø> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ladislas ladislas self-assigned this Nov 22, 2022
@ladislas ladislas added the 01 - type: task Something to do label Nov 22, 2022
@ladislas ladislas added this to the Future Release milestone Nov 22, 2022
@github-actions
Copy link

github-actions bot commented Nov 22, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 169508 (64%) 92636 (35%) 30920 (5%)
os 410984 (26%) 1153688 (73%) 79624 (15%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 410984 (19%) ø 79624 (15%) ø
bootloader ✔️ ✅ ✅ 169508 (8%) ø 30920 (5%) ø
functional_ut_boost_ut ✔️ ✅ ✅ 394076 (18%) ø 20456 (3%) ø
functional_ut_core_imu ✔️ ✅ ✅ 375780 (17%) ø 20424 (3%) ø
functional_ut_deep_sleep_log_kit ✔️ ✅ ✅ 352696 (16%) ø 20408 (3%) ø
functional_ut_deep_sleep_mbed_hal ✔️ ✅ ✅ 354216 (16%) ø 20408 (3%) ø
functional_ut_file_manager ✔️ ✅ ✅ 374536 (17%) ø 20696 (3%) ø
functional_ut_io_expander ✔️ ✅ ✅ 359232 (17%) ø 20424 (3%) ø
functional_ut_qdac ✔️ ✅ ✅ 360400 (17%) ø 20424 (3%) ø
spike_lk_accel_gyro ✔️ ✅ ✅ 71184 (3%) ø 11808 (2%) ø
spike_lk_audio ✔️ ✅ ✅ 125076 (5%) ø 14568 (2%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 189944 (9%) ø 48136 (9%) ø
spike_lk_ble ✔️ ✅ ✅ 228768 (10%) ø 28200 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 82948 (3%) ø 11544 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 144696 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65776 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ ✅ ✅ 192712 (9%) ø 50960 (9%) ø
spike_lk_config_kit ✔️ ✅ ✅ 126956 (6%) ø 14312 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 76164 (3%) ø 13688 (2%) ø
spike_lk_core_touch_sensor ✔️ ✅ ✅ 80228 (3%) ø 12256 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74800 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 139016 (6%) ø 14416 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 327112 (15%) ø 27576 (5%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_fs ✔️ ✅ ✅ 174808 (8%) ø 47904 (9%) ø
spike_lk_lcd ✔️ ✅ ✅ 162428 (7%) ø 46632 (8%) ø
spike_lk_led_kit ✔️ ✅ ✅ 103992 (4%) ø 14608 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 63288 (3%) ø 12256 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62600 (2%) ø 11488 (2%) ø
spike_lk_qdac ✔️ ✅ ✅ 78628 (3%) ø 11816 (2%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 103480 (4%) ø 14608 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 78884 (3%) ø 11504 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 67048 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ ✅ ✅ 114308 (5%) ø 14056 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 126092 (6%) ø 15296 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 80060 (3%) ø 13272 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 58032 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@github-actions
Copy link

github-actions bot commented Nov 22, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 182028 (69%) 80116 (30%) 41616 (7%)
os 452036 (28%) 1112636 (71%) 90840 (17%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 452036 (21%) ø 90840 (17%) ø
bootloader ✔️ ✅ ✅ 182028 (8%) ø 41616 (7%) ø
functional_ut_boost_ut ✔️ ✅ ✅ 408872 (19%) ø 30096 (5%) ø
functional_ut_core_imu ✔️ ✅ ✅ 387112 (18%) ø 30064 (5%) ø
functional_ut_deep_sleep_log_kit ✔️ ✅ ✅ 365284 (17%) ø 30976 (5%) ø
functional_ut_deep_sleep_mbed_hal ✔️ ✅ ✅ 366488 (17%) ø 30560 (5%) ø
functional_ut_file_manager ✔️ ✅ ✅ 386080 (18%) ø 30344 (5%) ø
functional_ut_io_expander ✔️ ✅ ✅ 370556 (17%) ø 30064 (5%) ø
functional_ut_qdac ✔️ ✅ ✅ 371716 (17%) ø 30064 (5%) ø
spike_lk_accel_gyro ✔️ ✅ ✅ 94048 (4%) ø 22568 (4%) ø
spike_lk_audio ✔️ ✅ ✅ 135196 (6%) ø 25144 (4%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 198508 (9%) ø 58712 (11%) ø
spike_lk_ble ✔️ ✅ ✅ 236780 (11%) ø 39016 (7%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 92364 (4%) ø 22224 (4%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 152392 (7%) ø 57224 (10%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88480 (4%) ø 24376 (4%) ø
spike_lk_command_kit ✔️ ✅ ✅ 203036 (9%) ø 62048 (11%) ø
spike_lk_config_kit ✔️ ✅ ✅ 138932 (6%) ø 25136 (4%) ø
spike_lk_coreled ✔️ ✅ ✅ 88044 (4%) ø 24264 (4%) ø
spike_lk_core_touch_sensor ✔️ ✅ ✅ 92884 (4%) ø 22832 (4%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84152 (4%) ø 22904 (4%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 154048 (7%) ø 25496 (4%) ø
spike_lk_file_reception ✔️ ✅ ✅ 331308 (15%) ø 38232 (7%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 86776 (4%) ø 22216 (4%) ø
spike_lk_fs ✔️ ✅ ✅ 174168 (8%) ø 47992 (9%) ø
spike_lk_lcd ✔️ ✅ ✅ 172268 (8%) ø 57464 (10%) ø
spike_lk_led_kit ✔️ ✅ ✅ 115772 (5%) ø 25184 (4%) ø
spike_lk_log_kit ✔️ ✅ ✅ 84776 (4%) ø 23408 (4%) ø
spike_lk_motors ✔️ ✅ ✅ 86072 (4%) ø 22248 (4%) ø
spike_lk_qdac ✔️ ✅ ✅ 91572 (4%) ø 22776 (4%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 112316 (5%) ø 25184 (4%) ø
spike_lk_rfid ✔️ ✅ ✅ 84080 (4%) ø 22184 (4%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 87184 (4%) ø 23280 (4%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 84072 (4%) ø 22216 (4%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 84824 (4%) ø 22216 (4%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90400 (4%) ø 22192 (4%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 91672 (4%) ø 22456 (4%) ø
spike_lk_serial_number ✔️ ✅ ✅ 136316 (6%) ø 25056 (4%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 82712 (3%) ø 22232 (4%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 148044 (7%) ø 26064 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100456 (4%) ø 23240 (4%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 87320 (4%) ø 24120 (4%) ø
spike_lk_wifi ✔️ ✅ ✅ 130832 (6%) ø 25528 (4%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84176 (4%) ø 23080 (4%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 83488 (3%) ø 22304 (4%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

YannLocatelli
YannLocatelli requested changes Nov 23, 2022
View reviewed changes
Copy link
Member

@YannLocatelli YannLocatelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better in my opinion to keep it the most explicit possible the origin of some used classe/interface/variable (e.g. interface::STM32Hal, interface::File, JPEGImageProperties, jpeg::JPEG_SOI_MARKER) and not popping from nowhere.

Same from standard libs, #include <array> is indeed not relevant in header file but it is used in source and might lead to unknownstd::array warning/error

@ladislas ladislas force-pushed the ladislas/bugfix/ut-corejpeg-missing-include branch from cc86c0d to aa00c55 Compare November 23, 2022 22:39
@ladislas ladislas force-pushed the ladislas/bugfix/ut-corejpeg-missing-include branch from aa00c55 to aa7386b Compare November 23, 2022 22:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ladislas ladislas merged commit d0f799d into develop Nov 23, 2022
@ladislas ladislas deleted the ladislas/bugfix/ut-corejpeg-missing-include branch November 23, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YannLocatelli YannLocatelli YannLocatelli approved these changes

Assignees

@ladislas ladislas

Labels
01 - type: task Something to do
Projects
None yet
Milestone
Future Release
Development

Successfully merging this pull request may close these issues.
2 participants
@ladislas @YannLocatelli