-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ladislas/feature/cleanup makefile #1068
Conversation
ladislas
commented
Oct 17, 2022
- 🔨 (tools): Remove term target
- 🎨 (Makefile): Reorganize configs, arguments
- 🔨 (Makefile): Rename FIRMWARE_VERSION -> OS_VERSION
- 🔨 (Makefile): Add target firmware_no_cleanup
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff listNo differenes where found in map files. |
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff listNo differenes where found in map files. |
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## develop #1068 +/- ##
========================================
Coverage 96.00% 96.00%
========================================
Files 133 133
Lines 3178 3178
========================================
Hits 3051 3051
Misses 127 127 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
firmware_no_cleanup: | ||
python3 tools/check_version.py ./config/os_version | ||
./tools/firmware/build_firmware.sh -v $(OS_VERSION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this target for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when you're already configured the project to build the firmware and make changes in os/main.cpp
you don't want to clean up everything and start from scratch each time.
especially when you live in Bretagne and the internet is super slow and it takes ~5/10min to download the dependencies for the project 😂