🔀 Merge branch 'ladislas/bugfix/math-utils-divide-zero' into develop

leka · Sep 22, 2022 · a2ea7e7 · a2ea7e7
2 parents daa9517 + 3541487
commit a2ea7e7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/libs/Utils/include/MathUtils.h b/libs/Utils/include/MathUtils.h
@@ -10,7 +10,8 @@
 namespace leka::utils::math {
 
 template <typename OutputType, typename IntputType>
-auto map(IntputType x, IntputType in_min, IntputType in_max, OutputType out_min, OutputType out_max) -> OutputType
+constexpr auto map(IntputType x, IntputType in_min, IntputType in_max, OutputType out_min, OutputType out_max)
+	-> OutputType
 {
 	return (x - in_min) * (out_max - out_min) / (in_max - in_min) + out_min;
 }

diff --git a/libs/Utils/tests/MathUtils_test_random8.cpp b/libs/Utils/tests/MathUtils_test_random8.cpp
@@ -22,10 +22,3 @@ TEST(MathUtilsTest, RandomBetween0And255)
 	EXPECT_GE(random, 0);
 	EXPECT_LE(random, 255);
 }
-
-TEST(MathUtilsTest, RandomBetweenOutsideOfRange)
-{
-	auto random = random8(300, 500);
-	EXPECT_GE(random, 0);
-	EXPECT_LE(random, 255);
-}