Skip to content

Commit

Permalink
πŸ”₯ (cmake): Remove CODE_ANALYSIS
Browse files Browse the repository at this point in the history
CODE_ANALYSIS was done using cppcheck. Now that we have SonarCloud, we
can remove local code analysis.
  • Loading branch information
ladislas committed Jan 12, 2022
1 parent ea62320 commit 0a76530
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 34 deletions.
24 changes: 0 additions & 24 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,30 +11,6 @@ if(CCACHE)
set(CMAKE_CXX_COMPILER_LAUNCHER "${CCACHE}")
endif(CCACHE)

# Activate code analysis
option(ENABLE_CODE_ANALYSIS "Run code analysis" OFF)
message(STATUS "ENABLE_CODE_ANALYSIS --> ${ENABLE_CODE_ANALYSIS}")

if(ENABLE_CODE_ANALYSIS)
find_program(CPPCHECK "cppcheck")
if(CPPCHECK)
set(CMAKE_CXX_CPPCHECK "${CPPCHECK}"
"--platform=${CMAKE_CURRENT_SOURCE_DIR}/tools/config/cppcheck_leka_platform.xml"
"--std=c++17"
"--cppcheck-build-dir=build/cppcheck"
"--enable=all"
"--inconclusive"
"--inline-suppr"
"--quiet"
"--suppress=unmatchedSuppression"
"--suppress=missingIncludeSystem"
"--suppress=*:*extern/mbed-os\*"
"--template=πŸ”₯ warning: {id} ({severity}): {message}\\n in {file}:{line}\\n{code}"
# "--check-config"
)
endif(CPPCHECK)
endif(ENABLE_CODE_ANALYSIS)

# Activate LogKit
option(ENABLE_LOG_DEBUG "Enable LogKit output" OFF)
message(STATUS "ENABLE_LOG_DEBUG --> ${ENABLE_LOG_DEBUG}")
Expand Down
12 changes: 2 additions & 10 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ TARGET_BOARD ?= LEKA_V1_2_DEV
#

ENABLE_LOG_DEBUG ?= OFF
ENABLE_CODE_ANALYSIS ?= OFF
BUILD_TARGETS_TO_USE_WITH_BOOTLOADER ?= OFF

#
Expand Down Expand Up @@ -122,12 +121,12 @@ config_tools_target: mkdir_cmake_config
config_cmake_build: mkdir_tools_config
@echo ""
@echo "πŸƒ Running cmake configuration script for target $(TARGET_BOARD) πŸ“"
@cmake -S . -B $(TARGET_BUILD_DIR) -GNinja -DCMAKE_CONFIG_DIR="$(CMAKE_CONFIG_DIR)" -DTARGET_BOARD="$(TARGET_BOARD)" -DCMAKE_BUILD_TYPE=$(BUILD_TYPE) -DENABLE_LOG_DEBUG=$(ENABLE_LOG_DEBUG) -DENABLE_CODE_ANALYSIS=$(ENABLE_CODE_ANALYSIS) -DBUILD_TARGETS_TO_USE_WITH_BOOTLOADER=$(BUILD_TARGETS_TO_USE_WITH_BOOTLOADER)
@cmake -S . -B $(TARGET_BUILD_DIR) -GNinja -DCMAKE_CONFIG_DIR="$(CMAKE_CONFIG_DIR)" -DTARGET_BOARD="$(TARGET_BOARD)" -DCMAKE_BUILD_TYPE=$(BUILD_TYPE) -DENABLE_LOG_DEBUG=$(ENABLE_LOG_DEBUG) -DBUILD_TARGETS_TO_USE_WITH_BOOTLOADER=$(BUILD_TARGETS_TO_USE_WITH_BOOTLOADER)

config_tools_build: mkdir_tools_config
@echo ""
@echo "πŸƒ Running cmake configuration script for target $(TARGET_BOARD) πŸ“"
@cmake -S . -B $(CMAKE_TOOLS_BUILD_DIR) -GNinja -DCMAKE_CONFIG_DIR="$(CMAKE_TOOLS_CONFIG_DIR)" -DTARGET_BOARD="$(TARGET_BOARD)" -DCMAKE_BUILD_TYPE=$(BUILD_TYPE) -DENABLE_LOG_DEBUG=ON -DENABLE_CODE_ANALYSIS=$(ENABLE_CODE_ANALYSIS)
@cmake -S . -B $(CMAKE_TOOLS_BUILD_DIR) -GNinja -DCMAKE_CONFIG_DIR="$(CMAKE_TOOLS_CONFIG_DIR)" -DTARGET_BOARD="$(TARGET_BOARD)" -DCMAKE_BUILD_TYPE=$(BUILD_TYPE) -DENABLE_LOG_DEBUG=ON
@ln -sf $(CMAKE_TOOLS_BUILD_DIR)/compile_commands.json ./

#
Expand Down Expand Up @@ -243,13 +242,6 @@ clang_tidy_diff_fix:
| grep -E -v "_test" | grep -E "^A|^M" | sed "s/^[AM]\t//g" | grep -E "\.h\$$|\.cpp\$$" \
| xargs /usr/local/opt/llvm/bin/clang-tidy -p=. --quiet --fix --fix-errors

code_analysis: mkdir_build
@echo ""
@echo "πŸƒβ€β™‚οΈ Running cppcheck code analysis πŸ”¬"
@mkdir -p $(PROJECT_BUILD_DIR)/cppcheck
cmake -S . -B $(PROJECT_BUILD_DIR)/cppcheck -GNinja -DTARGET_BOARD="$(TARGET_BOARD)" -DCMAKE_BUILD_TYPE=$(BUILD_TYPE) -DENABLE_CODE_ANALYSIS=ON
cmake --build $(PROJECT_BUILD_DIR)/cppcheck

#
# MARK: - Mbed targets
#
Expand Down

0 comments on commit 0a76530

Please sign in to comment.