Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape plus sign in the username #271

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Conversation

KapJI
Copy link
Collaborator

@KapJI KapJI commented Jul 5, 2022

Apparently I was able to create Google account (not email) which has + in the username. And to get master token for it, + should be replaced with %2B.

Fixes #260

@KapJI KapJI added the feature New feature or request label Jul 5, 2022
@KapJI KapJI requested a review from leikoilja July 5, 2022 14:03
@KapJI KapJI merged commit 1435b1c into leikoilja:master Jul 11, 2022
@KapJI KapJI deleted the escape-plus branch July 11, 2022 11:01
@leikoilja
Copy link
Owner

haha what de heck is this google thing... :D nice find and fix thou! Thanks

@KapJI KapJI added patch Patch changes. Used for release bump feature New feature or request and removed feature New feature or request patch Patch changes. Used for release bump labels Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

403 when trying to get master token
2 participants