This repository has been archived by the owner on Dec 19, 2021. It is now read-only.
Implement embedding a Trinary Search Tree #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is good for a lot of small files - fill the tree, GOB encode, gzip then store as base64 in the source. On init, the code decodes the base64, uncompresses, decodes, then fills the names slice and the values map from the tree. Benchmarks with the zoneinfo.zip: $ rm zoneinfo/*.go; time embedfiles -out zoneinfo/zi.go -pkg=tz -trie=false zoneinfo/ ; ls -l zoneinfo/*.go real 0m1,276s user 0m1,599s sys 0m0,033s -rw-r--r-- 1 gthomas gthomas 2721295 jan 25 15:51 zoneinfo/zi.go $ rm zoneinfo/*.go; time embedfiles -out zoneinfo/zi.go -pkg=tz -trie=true zoneinfo/ ; ls -l zoneinfo/*.go real 0m0,045s user 0m0,031s sys 0m0,019s -rw-r--r-- 1 gthomas gthomas 295428 jan 25 15:51 zoneinfo/zi.go So a tenfold decrease in source size.
|
Hi @tgulacsi, wow thanks for optimizing how the files are stored. I wouldn't have expected such a huge time and space saving, but I guess it makes sense as I'm not really doing anything for performance. Do you know how much benefit we get from using only one or the other? i.e. Does gzipping the files by itself cause a significant speed benefit as well, or is the speed benefit all from the TST? |
It is slower ans bigger than the GOB'd trie, buf less then a third in time and size than the original. $ time embedfiles -out=zoneinfo.go -pkg=tz -trie=true zoneinfo/; l zoneinfo.go real 0m0,033s user 0m0,025s sys 0m0,013s -rw-r--r-- 1 gthomas gthomas 295091 febr 4 18:08 zoneinfo.go :gthomas@redpath: ~/src/github.com/leighmcculloch/go-tz $ time embedfiles -out=zoneinfo.go -pkg=tz -gzip=true zoneinfo/; l zoneinfo.go real 0m0,310s user 0m0,473s sys 0m0,032s -rw-r--r-- 1 gthomas gthomas 602555 febr 4 18:08 zoneinfo.go :gthomas@redpath: ~/src/github.com/leighmcculloch/go-tz $ time embedfiles -out=zoneinfo.go -pkg=tz -gzip=false zoneinfo/; l zoneinfo.go real 0m1,334s user 0m1,604s sys 0m0,045s -rw-r--r-- 1 gthomas gthomas 2721247 febr 4 18:08 zoneinfo.go
|
The fastest and less memory consuming would be to uncompress only when retrieving the file - so no map, just the file name list, and a function to retrieve (decode & uncompress) the data (zoneinfo). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is good for a lot of small files - fill the tree,
GOB encode, gzip then store as base64 in the source.
On init, the code decodes the base64, uncompresses, decodes,
then fills the names slice and the values map from the tree.
Benchmarks with the zoneinfo.zip:
$ rm zoneinfo/.go; time embedfiles -out zoneinfo/zi.go -pkg=tz -trie=false zoneinfo/ ; ls -l zoneinfo/.go
real 0m1,276s
user 0m1,599s
sys 0m0,033s
-rw-r--r-- 1 gthomas gthomas 2721295 jan 25 15:51 zoneinfo/zi.go
$ rm zoneinfo/.go; time embedfiles -out zoneinfo/zi.go -pkg=tz -trie=true zoneinfo/ ; ls -l zoneinfo/.go
real 0m0,045s
user 0m0,031s
sys 0m0,019s
-rw-r--r-- 1 gthomas gthomas 295428 jan 25 15:51 zoneinfo/zi.go
So a tenfold decrease in source size.