Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reading of vlen strings #124

Merged
merged 3 commits into from
Dec 8, 2024
Merged

fix reading of vlen strings #124

merged 3 commits into from
Dec 8, 2024

Conversation

ManuelHu
Copy link
Contributor

@ManuelHu ManuelHu commented Dec 7, 2024

Geant4 writes strings as variable length datatype, and they end up in LH5 files via the remage-to-lh5 conversion.

h5py reads them as object arrays, and attaches a vlen metadata property, so return a string datatype in this case.

@ManuelHu ManuelHu marked this pull request as draft December 7, 2024 22:21
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.38%. Comparing base (0104086) to head (b44409d).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   78.30%   78.38%   +0.07%     
==========================================
  Files          46       46              
  Lines        3384     3400      +16     
==========================================
+ Hits         2650     2665      +15     
- Misses        734      735       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ManuelHu ManuelHu marked this pull request as ready for review December 7, 2024 22:35
@gipert gipert merged commit 96b68d5 into legend-exp:main Dec 8, 2024
15 checks passed
@ManuelHu ManuelHu deleted the patch-1 branch December 8, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants