This repository has been archived by the owner on Dec 8, 2024. It is now read-only.
Handle case of .mill-version with Windows line ends #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a precaution for cases when the .mill-version file can contain a Windows line end `\r\n` instead of the typical Unix line end `\n`. Without this fix, in such situation the script breaks in a spectacular and surprising way.
|
Thank you for this contribution.
Do you have an example by any chance? |
|
The error it was giving looked like this: $ mill __.compile
.jar ...st-0.12.1o1.maven.org/maven2/com/lihaoyi/mill-dist/0.12.1
curl: (3) URL using bad/illegal format or missing URLWhere |
|
Archive with an example |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a precaution for cases when the
.mill-versionfile can contain a Windows line end\r\ninstead of the typical Unix line end\n. Without this fix, in such situation the script breaks in a spectacular and surprising way.