feat: add arbitrary message signing

[beguene]

Try out this version of the Hiro Wallet - download extension builds.

closes #1051

Pending Todos:

• Sign + hash the message flow
• Signature Popup UI
• Error Handling
• Finalise the signature popup flow and return the signature value to the dapp
• Improve test-app
• Update connect feat: support arbitrary message signing hirosystems/connect#205
• Add Prefix to messages, add convenient functions to stacks.js Add encode/decode message functions for Arbitrary Message Signing hirosystems/stacks.js#1231
• handle custom connect and stacks.js packages so QA can test easily

Decoding message as Clarity Value (see #2387)

signature-test-app.mov

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/blockstack/stacks-wallet-web/D9MRHTF5hcVk9wbX3mhYq4TN4U4x
✅ Preview: Failed

[beguene]

@landitus This is the current implementation (just the warning message at the bottom is missing). Let me know if you find any issue.

[landitus]

@beguene Since we've just updated the designs, lmk when you update them so I can do a review.

[beguene]

@landitus

[landitus]

Thanks @beguene! I can't run the package cause it's failing, but I can review the screenshots for now.

A few observations:

• Beware of the excess in spacing (top/bottom padding) in the hash drawer
• The hash can use the Fira code typography, which is available in the codebase and serves as a monospaced font for code and a lighter color: text.subdued
• The title "Message" is not needed
• For the actual message box:
  -- The rounded corners are a bit off. Check that they are 12px
  -- Is the height of the box declared or due to top/bottom padding? I think that when the messages are short, it's nice to have a larger box and when they are longer (like for the tupple) the box should fit it's contents. I think we could declared a min-height property to accomplish that.

[beguene]

@landitus Yes you can't use this build yet, I need to fix a few packages first.
Thanks for the comments, I will take into account your observations.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
stacks-wallet-web	✅ Ready (Inspect)	Visit Preview	May 11, 2022 at 7:38AM (UTC)

[kyranjamie]

This is going to conflict with my refactor 🙈

[landitus]

@landitus I fixed the issues you mentioned. Let me know if it's fine.

Thanks @beguene. this is looking very good! Just a few more comments I found

[beguene]

@landitus Thanks, those issues are fixed

Note that the separator is not exactly like in your design, it does not extend fully to the sides. If it's still an issue, I can fix it in a separate issue.

[Eshwari007]

@beguene Two quick findings/questions:
1-Learn more about signing messages is directing to https://www.hiro.so/
2- Do we want to reword 'to prove you own this account and more' as having more at the end felt like hanging sentence.

Let me know if you want me to create an enhancement ticket for the above.
cc @markmhx

[landitus]

Note that the separator is not exactly like in your design, it does not extend full to the sides. If it's still an issue, I can fix it in a separate issue.

I see @beguene. Let's leave for a separate issue if that helps the release. Also, we could improve the padding for the hash box a bit more in that same task. Want me to create a ticket? Thank you.

[markmhendrickson]

@sjwhitely it appears we do need an FAQ for this functionality after all. Mind drafting and providing its URL for integration? 🙏

[markmhendrickson]

Do we want to reword 'to prove you own this account and more' as having more at the end felt like hanging sentence.

I'd suggest improving this copy in general to:

By signing this message, you are authorizing "Testing App" to do something specific on your behalf. Only sign messages that you understand from apps that you trust. Learn more

[beguene]

@Eshwari007 @markmhx I updated the copy.

[Eshwari007]

@beguene Two quick findings/questions: 1-Learn more about signing messages is directing to https://www.hiro.so/ 2- Do we want to reword 'to prove you own this account and more' as having more at the end felt like hanging sentence.

Let me know if you want me to create an enhancement ticket for the above. cc @markmhx

@beguene The rewording of the dialogue message in arbitrary message is looking good. Will re test the link to 'Learn More' once @sjwhitely updates it.

Thanks