You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try out this version of the Stacks Wallet - download extension builds.
Description
This PR makes a few changes for the Chrome and Firefox to help improve the release workflow.
Now uses the chrome-webstore-upload-cli to upload and publish the Chrome extension. This CLI has much wider adoption than the previous GH Action we were using, can be ran locally in a pinch, and helps expose uploading/publishing errors:
yarn webstore upload --source stacks-wallet-chromium.zip --auto-publish
yarn run v1.22.4
Error Code: ITEM_NOT_UPDATABLE
Details: The item cannot be updated now because it is in pending review, ready to publish, or deleted status.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Now uses web-ext-submit instead of web-ext To sign and publish the Firefox extension. web-ext-submit is a simple wrapper around web-ext, except it prevents the inevitable and unrelated "it could not be signed error", which is a deep issue in the web-ext package. Despite the error, the package still gets uploaded for review just fine. This minor change should help reduce minor errors which otherwise fail the build regardless of the result.
Removed the Chrome and Firefox package uploads to the GH Actions page and GCP bucket. The FF package literally can never produce another signed and listed XPI package again until the web-ext issue is resolved. Thus, the steps to find and upload an XPI package will never work, so I removed it. I removed the Chrome upload to the GH summary and GCP because it would be missing its FF counterpart and it feels unnecessary since it's easy enough to create locally via sh build-ext.sh.
This PR does not definitively resolve upload issues for Chrome nor Firefox, but it should help expose the root underlying problem(s) involved with publishing, reduce failures due to unrelated errors, and allow us to more easily publish and test publishes locally if needed for any reason.
Type of Change
New feature
Bug fix
API reference/documentation update
Other
Does this introduce a breaking change?
The web-ext package was moved from regular dependencies to a dev dependency. I don't think it should have any effect though.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a few changes for the Chrome and Firefox to help improve the release workflow.
web-extTo sign and publish the Firefox extension.web-ext-submitis a simple wrapper aroundweb-ext, except it prevents the inevitable and unrelated "it could not be signed error", which is a deep issue in theweb-extpackage. Despite the error, the package still gets uploaded for review just fine. This minor change should help reduce minor errors which otherwise fail the build regardless of the result.web-extissue is resolved. Thus, the steps to find and upload an XPI package will never work, so I removed it. I removed the Chrome upload to the GH summary and GCP because it would be missing its FF counterpart and it feels unnecessary since it's easy enough to create locally viash build-ext.sh.Publish Extensionsfor disambiguation because there's a different workflow in the app.blockstack.org branch with the same name.Some Remaining Issues
This PR does not definitively resolve upload issues for Chrome nor Firefox, but it should help expose the root underlying problem(s) involved with publishing, reduce failures due to unrelated errors, and allow us to more easily publish and test publishes locally if needed for any reason.
Type of Change
Does this introduce a breaking change?
The
web-extpackage was moved from regular dependencies to a dev dependency. I don't think it should have any effect though.Are documentation updates required?
No.
Checklist