Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KDS to Studio: Replace ResponsiveDialog by KModal in SavedSearchesModal #3063

Merged
merged 3 commits into from
Apr 20, 2021
Merged

KDS to Studio: Replace ResponsiveDialog by KModal in SavedSearchesModal #3063

merged 3 commits into from
Apr 20, 2021

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Mar 31, 2021 •
edited
Loading

Summary

Description of the change(s) you made

Replace ResponsiveDialog by KModal in SavedSearchesModal

Manual verification steps performed

  1. Open the channel editor page for a channel that you can edit
  2. Click "ADD" dropdown button in the upper right corner
  3. Select "Import from channels"
  4. Type a search string to search input and click "SEARCH" button
  5. Click "View saved searches" (to see some searches in "Saved searches" modal, you can click "Save search" before opening the modal)

Screenshots

Before After
loading-before loading-after
no_searches-before no_searches-after
searches-before searches-after

Does this introduce any tech-debt items?

Nothing that I am aware of regarding Studio code.
I've discovered a bug in KDS that has been reported here.

Reviewer guidance

How can a reviewer test these changes?

Please follow "Manual verification steps"

Are there any risky areas that deserve extra testing?

Please check that you can edit and remove saved searches

References

Part of learningequality/kolibri-design-system#157

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob marked this pull request as ready for review April 1, 2021 06:59
@MisRob MisRob requested a review from marcellamaki April 1, 2021 06:59
MisRob
MisRob commented Apr 1, 2021
View reviewed changes
...uration/contentcuration/frontend/channelEdit/views/ImportFromChannels/SavedSearchesModal.vue
<VDivider v-if="index < savedSearches.length - 1" :key="index + 'divider'" />
</template>
</VList>
</KModal>

<MessageDialog
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't replaced MessageDialog and EditSearchModal with KModal because @marcellamaki already has some work in progress related to that.

@MisRob MisRob removed the request for review from marcellamaki April 1, 2021 12:24
@MisRob MisRob marked this pull request as draft April 1, 2021 12:26
@MisRob MisRob marked this pull request as ready for review April 15, 2021 08:01
@MisRob MisRob requested a review from marcellamaki April 15, 2021 08:02
marcellamaki
marcellamaki approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Nice work Misha :)

@MisRob MisRob merged commit ebad621 into learningequality:unstable Apr 20, 2021
@bjester bjester mentioned this pull request Apr 26, 2021
Merged
@pcenov
Copy link
Member

pcenov commented Apr 27, 2021

Tested today at https://hotfixes.studio.learningequality.org/ and the Saved searches modal is displayed correctly.
I've reported separately the following 2 issues:
#3117 - Saved searches - My saved search gets duplicated
#3118 - Saved searches - The entered search term is not updated after applying a saved search

Currently the saved searches are not the same for my different channels for example in Channel A I might have Search 1 and Search 2 while in Channel 2 I might have no saved searches at all or totally different saved searches. Is this intentional?

@radinamatic
Copy link
Member

Currently the saved searches are not the same for my different channels for example in Channel A I might have Search 1 and Search 2 while in Channel 2 I might have no saved searches at all or totally different saved searches. Is this intentional?

This does not seem to be the case on my side, the same list of all my saved searches (plus the duplicates 😛) appears in all the channels.

@pcenov
Copy link
Member

pcenov commented Apr 29, 2021

Currently the saved searches are not the same for my different channels for example in Channel A I might have Search 1 and Search 2 while in Channel 2 I might have no saved searches at all or totally different saved searches. Is this intentional?

This does not seem to be the case on my side, the same list of all my saved searches (plus the duplicates 😛) appears in all the channels.

Yeah, I'm not able to replicate that issue today as well. How bizarre... :)

@MisRob MisRob deleted the kds-kmodal-responsivedialog-savedsearchesmodal branch September 15, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcellamaki marcellamaki marcellamaki approved these changes

Assignees
No one assigned
Labels
DEV: frontend TAG: user strings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MisRob @pcenov @radinamatic @marcellamaki