Fix Postgres issue not dropping null constraint #154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In #143 we revised an existing migration which added new columns to make the fields nullable. In addition, we created another migration that also drops the null constraint if the previous migration had already ran. This appears to work fine for SQLite but not for PostgreSQL due to something internal to Django (1.11 at least which is used in Kolibri).
Summary
TODO
Reviewer guidance
migrate_to
of the test to the new migrationIssues addressed
learningequality/kolibri#9139
Documentation
If the PR has documentation, link the file here (either .rst in your repo or if built on Read The Docs)