add .trim to v-model for username

[marcellamaki]

Summary

Adds .trim to the v-model for username on login, so that adding a space before or after the username does not cause a validation failure.

References

Fixes #9471

Reviewer guidance

1. Log in with an existing account, adding a space both before and after the username. The log in should work
2. After entering a username with whitespace and advancing to enter the password, click "change user". This should work and return to a blank form
3. Add a space or a special character in the middle of the username. This should fail validation

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0.dev0_git.20220614130242.pex
Unsigned Windows installer	kolibri-0.16.0.dev0+git.20220614130242-unsigned.exe
Debian Package	kolibri_0.16.0.dev0+git.20220614130242-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0.dev0+git.20220614130242-0.3.0.dmg
Source Tarball	kolibri-0.16.0.dev0+git.20220614130242.tar.gz
WHL file	kolibri-0.16.0.dev0+git.20220614130242-py2.py3-none-any.whl

[radinamatic]

Trimming the before and after white space in the username (and reporting an error if it's in the middle) is working a-Ok! 👍🏽

I'm only wondering if we should do the same for passwords...? 🤔
In the recording below, the same situation occurs when an accidental white space is introduced before or after the password, resulting in the Incorrect password message. Thinking really hard if there are any downsides to implementing the same trimming here, and I'm coming up empty...

[rtibbles]

Thinking really hard if there are any downsides to implementing the same trimming here, and I'm coming up empty...

The main downside I can see is that if someone does have a space at the beginning or end of their password, they will never be able to login.

I did a quick scan of the code, and I can't find any place that we do actually remove whitespace from passwords, so it's very possible these may exist. It's also possible I missed where we do this - so if we are already making sure of this, then this change would be ok.

[radinamatic]

if someone does have a space at the beginning or end of their password, they will never be able to login.

But no one is able to save (create account using) the password with the whitespace anyways, as there's an error notification in place for that, right?

[rtibbles]

as there's an error notification in place for that, right?

Is there? That's what I was unsure about - whether we do trim or error in this case.

[radinamatic]

I was convinced there was the error notification in that case, but after re-checking both 0.15.2 and the asset from this PR, I'm not able to find one (must have been 🤓 dreaming...).

So yes, given the above it is unwise to implement the trim for passwords, let's merge this then!

[radinamatic]

LGTM! 💯

[rtibbles]

OK, I think github actions have got confused because this was originally targeted to the develop branch, so the Python 3.4 and 3.5 tests did not run. They should not be affected, so this is safe to merge.