-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quiz report visibility control for coaches #13064
Open
LianaHarris360
wants to merge
13
commits into
learningequality:develop
Choose a base branch
from
LianaHarris360:quiz-report-visibility-control
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
09301e8
Update exam model, views, and api with instant_report_visibility fiel…
LianaHarris360 3b64d66
Add exam field instant_report_visibility for use in the frontend
LianaHarris360 e39ccdb
Update commonCoachStrings with new strings for report visibility sele…
LianaHarris360 39bb753
Add report visibility selection button to frontend quiz creation
LianaHarris360 fa607e3
Add report visibility label & description to quiz status page
LianaHarris360 972728c
Update learner view to show quiz reports only if the exam is closed o…
LianaHarris360 272a948
Update exam api tests with instant_report_visibility field
LianaHarris360 80645ac
Set data prop instantReportVisibility using assignment.instant_report…
LianaHarris360 41f8f75
Set instantReportVisibility to default assignment instant_report_visi…
LianaHarris360 39a71e1
Update exam instant_report_visibility field with null=True and defaul…
LianaHarris360 d026a02
Display the report visibility timestamp as exam archive date if insta…
LianaHarris360 c4fca87
Add updated migration field operations for exams
LianaHarris360 995180c
Return true for null instant_report_visibility values
LianaHarris360 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
kolibri/core/exams/migrations/0010_add_exam_report_visibility_field.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# Generated by Django 3.2.25 on 2025-02-20 17:37 | ||
from django.db import migrations | ||
from django.db import models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
("exams", "0009_alter_exam_date_created"), | ||
] | ||
|
||
operations = [ | ||
migrations.AddField( | ||
model_name="draftexam", | ||
name="instant_report_visibility", | ||
field=models.BooleanField(null=True), | ||
), | ||
migrations.AddField( | ||
model_name="exam", | ||
name="instant_report_visibility", | ||
field=models.BooleanField(null=True), | ||
), | ||
migrations.AlterField( | ||
model_name="draftexam", | ||
name="instant_report_visibility", | ||
field=models.BooleanField(default=True, null=True), | ||
), | ||
migrations.AlterField( | ||
model_name="exam", | ||
name="instant_report_visibility", | ||
field=models.BooleanField(default=True, null=True), | ||
), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I can think of here, is that we should probably return
True
for this if the backend value isnull
- that will save the frontend from having to worry about the nullability of the field, and leave it entirely as a backend concern (as we only really introduced it for the purposes of migration).