-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix snackbar errors in content import #12946
Fix snackbar errors in content import #12946
Conversation
…if the consuming component also defines setup.
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get the "Task finished" snackbar but I don't suspect that is related to your changes here.
I have a video but GH isn't uploading it correctly ping me on Slack if you want it
Yeah, I also confirm that "Task started" is shown correctly every time, but no trace of "Task finished". Checked in Kolibri 0.17.4 and it's not shown there as well, so this might have been broken a long time ago. |
@pcenov could you file an issue for the lack of Task Finished? Interesting that it's happening in 0.17 as well, because that's before we did a bunch of changes here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and w/ the follow-up issue filed this is good to go
e99a9bb
into
learningequality:develop
Summary
References
Follow up from #12933
Reviewer guidance
Import content into Kolibri, confirm that snackbars are displayed, without errors, and that redirects happen properly