Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move navroute generation into usenav composable. #12701

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Oct 3, 2024

Summary

  • Turns the navItems export of the useNav composable into a computed prop
  • Does generate nav items inside the use nav composable, instead of inside the core menu option and bottom navigation bar components - exposes subroute href as href property

References

In support of #5488

Reviewer guidance

Test that the side nav, top nav bar, and bottom nav bar all behave as expected without regressions.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles force-pushed the generate_nav_routes_once branch from b2782f8 to fc1222b Compare October 3, 2024 15:49
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review looks good and manual QA checks out on main nav, side nav, and app bottom nav, including cross-plugin navigation into sub-routes

@marcellamaki marcellamaki merged commit 7ae3a3d into learningequality:develop Oct 3, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants