Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release upload fixes #12050

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Apr 4, 2024

Summary

  • Updates the path specification for upload to GCS to include the extra folder that the Github download artifacts action adds when multiple artifacts are uploaded from different action steps.
  • Updates the Raspberry Pi image generator and Windows installer actions to versions that name the outputted files in accordance with the expectations for our release assets.
  • Fixes oversight where the Mac App generation was not pinned in the PR build

References

Fixes #11908

Reviewer guidance

Because of how the action works, we'll have to wait for release to truly test it - but a quick eyeball of the changes (making sure that the @ tags on the actions match up with the ref inputs) would be helpful. Also, we can check the names of the built asset for the Windows installer in this PR.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

rtibbles added 2 commits April 2, 2024 14:34
… nested folder download-artifact puts it in.
Update Windows and Pi installer versions.
@rtibbles rtibbles added this to the Kolibri 0.16: Planned Patch 1 milestone Apr 4, 2024
@github-actions github-actions bot added DEV: dev-ops Continuous integration & deployment SIZE: small labels Apr 4, 2024
@@ -184,13 +184,13 @@ jobs:
- name: Upload files to Google Cloud Storage
uses: 'google-github-actions/upload-cloud-storage@v2'
with:
path: 'dist/${{ matrix.filename }}'
path: 'dist/${{ matrix.filename }}/${{ matrix.filename }}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is ${{ matrix.filename }} in here twice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because of this fun quirk of the download-artifacts action: https://github.com/actions/download-artifact?tab=readme-ov-file#download-all-artifacts

Basically, artifacts get downloaded into a folder with the same name as the file, for reasons that I have still not adequately understood :)

@marcellamaki marcellamaki self-requested a review April 4, 2024 20:20
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - I did a search for the past references to ensure all were updated, and cross referenced the versions with the latest releases. all checks out.

@marcellamaki marcellamaki merged commit ac7ed7c into learningequality:release-v0.16.x Apr 4, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: dev-ops Continuous integration & deployment SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants