-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release upload fixes #12050
Release upload fixes #12050
Conversation
… nested folder download-artifact puts it in.
Update Windows and Pi installer versions.
@@ -184,13 +184,13 @@ jobs: | |||
- name: Upload files to Google Cloud Storage | |||
uses: 'google-github-actions/upload-cloud-storage@v2' | |||
with: | |||
path: 'dist/${{ matrix.filename }}' | |||
path: 'dist/${{ matrix.filename }}/${{ matrix.filename }}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is ${{ matrix.filename }}
in here twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because of this fun quirk of the download-artifacts action: https://github.com/actions/download-artifact?tab=readme-ov-file#download-all-artifacts
Basically, artifacts get downloaded into a folder with the same name as the file, for reasons that I have still not adequately understood :)
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - I did a search for the past references to ensure all were updated, and cross referenced the versions with the latest releases. all checks out.
ac7ed7c
into
learningequality:release-v0.16.x
Summary
References
Fixes #11908
Reviewer guidance
Because of how the action works, we'll have to wait for release to truly test it - but a quick eyeball of the changes (making sure that the @ tags on the actions match up with the
ref
inputs) would be helpful. Also, we can check the names of the built asset for the Windows installer in this PR.Testing checklist
PR process
Reviewer checklist
yarn
andpip
)