Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent KDS imports across the whole Kolibri #11742

Merged
merged 5 commits into from
Jan 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions kolibri/core/assets/src/core-app/apiSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,6 @@

import vue from 'vue';
import vuex from 'vuex';
import UiAlert from 'kolibri-design-system/lib/keen/UiAlert';
import responsiveWindowMixin from 'kolibri-design-system/lib/KResponsiveWindowMixin';
import responsiveElementMixin from 'kolibri-design-system/lib/KResponsiveElementMixin';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import useKShow from 'kolibri-design-system/lib/composables/useKShow';
import UiIconButton from 'kolibri-design-system/lib/keen/UiIconButton'; // temp hack
import * as vueCompositionApi from '@vue/composition-api';
import logging from '../logging';
import * as apiResource from '../api-resource';
Expand Down Expand Up @@ -188,8 +182,6 @@ export default {
MultiPaneLayout,
CoreFullscreen,
CoreLogo,
UiAlert,
UiIconButton,
UiToolbar,
PrivacyInfoModal,
UserTypeDisplay,
Expand Down Expand Up @@ -221,16 +213,12 @@ export default {
},
router,
mixins: {
responsiveWindowMixin,
responsiveElementMixin,
commonCoreStrings,
commonTaskStrings,
commonSyncElements,
translatedUserKinds,
},
composables: {
useKResponsiveWindow,
useKShow,
useMinimumKolibriVersion,
useUser,
useUserSyncStatus,
Expand Down
2 changes: 1 addition & 1 deletion kolibri/core/assets/src/views/AppBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
import KIconButton from 'kolibri-design-system/lib/buttons-and-links/KIconButton';
import themeConfig from 'kolibri.themeConfig';
import { isTouchDevice } from 'kolibri.utils.browserInfo';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import navComponentsMixin from '../mixins/nav-components';
import SkipNavigationLink from './SkipNavigationLink';

Expand Down
2 changes: 1 addition & 1 deletion kolibri/core/assets/src/views/CorePage/AppBarPage.vue
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
import { throttle } from 'frame-throttle';
import LanguageSwitcherModal from 'kolibri.coreVue.components.LanguageSwitcherModal';
import ScrollingHeader from 'kolibri.coreVue.components.ScrollingHeader';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import SideNav from 'kolibri.coreVue.components.SideNav';
import { LearnerDeviceStatus } from 'kolibri.coreVue.vuex.constants';
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
import Navbar from 'kolibri.coreVue.components.Navbar';
import NavbarLink from 'kolibri.coreVue.components.NavbarLink';
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';

export default {
name: 'HorizontalNavBarWithOverflowMenu',
Expand Down
2 changes: 1 addition & 1 deletion kolibri/core/assets/src/views/InteractionList/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

<script>

import responsiveElementMixin from 'kolibri.coreVue.mixins.responsiveElementMixin';
import responsiveElementMixin from 'kolibri-design-system/lib/KResponsiveElementMixin';
import InteractionItem from './InteractionItem';

export default {
Expand Down
2 changes: 1 addition & 1 deletion kolibri/core/assets/src/views/MultiPaneLayout.vue
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<script>

import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import responsiveElementMixin from 'kolibri.coreVue.mixins.responsiveElementMixin';
import responsiveElementMixin from 'kolibri-design-system/lib/KResponsiveElementMixin';

export default {
name: 'MultiPaneLayout',
Expand Down
2 changes: 1 addition & 1 deletion kolibri/core/assets/src/views/Navbar/NavbarLink.vue
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<script>

import { validateLinkObject } from 'kolibri.utils.validators';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';

/**
Links for use inside the Navbar
Expand Down
2 changes: 1 addition & 1 deletion kolibri/core/assets/src/views/Navbar/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

<script>

import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
/**
* Used for navigation between sub-pages of a top-level Kolibri section
*/
Expand Down
2 changes: 1 addition & 1 deletion kolibri/core/assets/src/views/SideNav.vue
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
import { UserKinds, NavComponentSections } from 'kolibri.coreVue.vuex.constants';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import responsiveElementMixin from 'kolibri.coreVue.mixins.responsiveElementMixin';
import responsiveElementMixin from 'kolibri-design-system/lib/KResponsiveElementMixin';
import CoreMenu from 'kolibri.coreVue.components.CoreMenu';
import CoreMenuOption from 'kolibri.coreVue.components.CoreMenuOption';
import CoreLogo from 'kolibri.coreVue.components.CoreLogo';
Expand Down
2 changes: 1 addition & 1 deletion kolibri/core/assets/src/views/SlotTruncator.vue
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<script>

import debounce from 'lodash/debounce';
import responsiveElementMixin from 'kolibri.coreVue.mixins.responsiveElementMixin';
import responsiveElementMixin from 'kolibri-design-system/lib/KResponsiveElementMixin';
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';

export default {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@
import { ref } from 'kolibri.lib.vueCompositionApi';
import { get } from '@vueuse/core';
import { enhancedQuizManagementStrings } from 'kolibri-common/strings/enhancedQuizManagementStrings';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import Draggable from 'kolibri.coreVue.components.Draggable';
import DragContainer from 'kolibri.coreVue.components.DragContainer';
import DragHandle from 'kolibri.coreVue.components.DragHandle';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

<script>

import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';

/**
* @typedef {Object} Tab
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@

<script>

import responsiveWindowMixin from 'kolibri.coreVue.mixins.responsiveWindowMixin';
import responsiveWindowMixin from 'kolibri-design-system/lib/KResponsiveWindowMixin';
import { ref } from 'kolibri.lib.vueCompositionApi';
import pickBy from 'lodash/pickBy';
import BottomAppBar from 'kolibri.coreVue.components.BottomAppBar';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@
import CoreTable from 'kolibri.coreVue.components.CoreTable';
import CatchErrors from 'kolibri.utils.CatchErrors';
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
import useKShow from 'kolibri.coreVue.composables.useKShow';
import useKShow from 'kolibri-design-system/lib/composables/useKShow';
import bytesForHumans from 'kolibri.utils.bytesForHumans';
import CoachAppBarPage from '../../CoachAppBarPage';
import { LessonsPageNames } from '../../../constants/lessonsConstants';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@
import { availableLanguages, currentLanguage } from 'kolibri.utils.i18n';
import sortLanguages from 'kolibri.utils.sortLanguages';
import BottomAppBar from 'kolibri.coreVue.components.BottomAppBar';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import { checkCapability } from 'kolibri.utils.appCapabilities';
import commonDeviceStrings from '../commonDeviceStrings';
import DeviceAppBarPage from '../DeviceAppBarPage';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@
import Lockr from 'lockr';
import FocusLock from 'vue-focus-lock';
import CoreFullscreen from 'kolibri.coreVue.components.CoreFullscreen';
import responsiveElementMixin from 'kolibri.coreVue.mixins.responsiveElementMixin';
import responsiveElementMixin from 'kolibri-design-system/lib/KResponsiveElementMixin';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import iFrameView from './SandboxIFrameView';
import LoadingScreen from './LoadingScreen';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
SyncFacilityModalGroup,
} from 'kolibri.coreVue.componentSets.sync';
import commonSyncElements from 'kolibri.coreVue.mixins.commonSyncElements';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import { TaskResource, FacilityResource } from 'kolibri.resources';
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
import CoreMenu from 'kolibri.coreVue.components.CoreMenu';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@
<script>

import { mapActions, mapGetters, mapState } from 'vuex';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import { createTranslator } from 'kolibri.utils.i18n';

import camelCase from 'lodash/camelCase';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

import CoreInfoIcon from 'kolibri.coreVue.components.CoreInfoIcon';
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';

export default {
name: 'IdentifierTextbox',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { get } from '@vueuse/core';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import { computed } from 'kolibri.lib.vueCompositionApi';

export default function useCardLayoutSpan() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@
import { computed, getCurrentInstance } from 'kolibri.lib.vueCompositionApi';
import { get } from '@vueuse/core';
import { createTranslator } from 'kolibri.utils.i18n';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import useContentLink from '../../../composables/useContentLink';
import useDevices from '../../../composables/useDevices';
import useLearningActivities from '../../../composables/useLearningActivities';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

<script>

import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import useCardLayoutSpan from '../composables/useCardLayoutSpan';
import useContentLink from '../composables/useContentLink';
import ChannelCard from './ChannelCard';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
<script>

import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import useContentLink from '../../composables/useContentLink';
import { KolibriStudioId } from '../../constants';
import ChannelCardGroupGrid from '../ChannelCardGroupGrid';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@

import { get } from '@vueuse/core';
import { computed } from 'kolibri.lib.vueCompositionApi';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import coreStrings from 'kolibri.utils.coreStrings';
import useCardLayoutSpan from '../../composables/useCardLayoutSpan';
import useContentLink from '../../composables/useContentLink';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
<script>

import TextTruncatorCss from 'kolibri.coreVue.components.TextTruncatorCss';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';

export default {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@

import { onMounted, getCurrentInstance, ref, watch } from 'kolibri.lib.vueCompositionApi';
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import useUser from 'kolibri.coreVue.composables.useUser';
import samePageCheckGenerator from 'kolibri.utils.samePageCheckGenerator';
import { ContentNodeResource } from 'kolibri.resources';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
import debounce from 'lodash/debounce';
import BottomAppBar from 'kolibri.coreVue.components.BottomAppBar';
import UiAlert from 'kolibri-design-system/lib/keen/UiAlert';
import UiIconButton from 'kolibri.coreVue.components.UiIconButton';
import UiIconButton from 'kolibri-design-system/lib/keen/UiIconButton';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
import shuffled from 'kolibri.utils.shuffled';
Expand Down
2 changes: 1 addition & 1 deletion kolibri/plugins/learn/assets/src/views/SearchBox.vue
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<script>

import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
import responsiveElementMixin from 'kolibri.coreVue.mixins.responsiveElementMixin';
import responsiveElementMixin from 'kolibri-design-system/lib/KResponsiveElementMixin';

export default {
name: 'SearchBox',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@

import { NoCategories } from 'kolibri.coreVue.vuex.constants';
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import { ref } from 'kolibri.lib.vueCompositionApi';
import SearchBox from '../SearchBox';
import SidePanelModal from '../SidePanelModal';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

<script>

import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
import commonLearnStrings from '../commonLearnStrings';
import SidePanelModal from '../SidePanelModal';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@
import throttle from 'lodash/throttle';
import { languageIdToCode } from 'kolibri.utils.i18n';
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
import responsiveElementMixin from 'kolibri.coreVue.mixins.responsiveElementMixin';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import responsiveElementMixin from 'kolibri-design-system/lib/KResponsiveElementMixin';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import Settings from '../utils/settings';
import { ReplayButton, ForwardButton } from './customButtons';
import MediaPlayerFullscreen from './MediaPlayerFullscreen';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
// polyfill necessary for recycle list
import 'intersection-observer';
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import CoreFullscreen from 'kolibri.coreVue.components.CoreFullscreen';
import '../utils/domPolyfills';
import { EventBus } from '../utils/event_utils';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@
import LanguageSwitcherModal from 'kolibri.coreVue.components.LanguageSwitcherModal';
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
import AppError from 'kolibri-common/components/AppError';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import { availableLanguages, currentLanguage } from 'kolibri.utils.i18n';
import { FooterMessageTypes } from '../constants';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
import { interpret } from 'xstate';
import { mapState } from 'vuex';
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
import useKResponsiveWindow from 'kolibri.coreVue.composables.useKResponsiveWindow';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';
import { checkCapability } from 'kolibri.utils.appCapabilities';
import Lockr from 'lockr';
import { wizardMachine } from '../machines/wizardMachine';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
import objectFitImages from 'object-fit-images';
import client from 'kolibri.client';

import responsiveElementMixin from 'kolibri.coreVue.mixins.responsiveElementMixin';
import responsiveElementMixin from 'kolibri-design-system/lib/KResponsiveElementMixin';
import useKResponsiveWindow from 'kolibri-design-system/lib/useKResponsiveWindow';

import UiIconButton from 'kolibri-design-system/lib/keen/UiIconButton';
Expand Down