-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace question sidepanel #11497
Closed
AllanOXDi
wants to merge
19
commits into
learningequality:develop
from
AllanOXDi:replace_question_sidepanel
Closed
Replace question sidepanel #11497
AllanOXDi
wants to merge
19
commits into
learningequality:develop
from
AllanOXDi:replace_question_sidepanel
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran into some issues w/ the way the overflow calculation was done as I tried to adjust the heights of the tabs and their containers themselves This ultimately ends up losing some items which were impacting the calculations which will be fixed in a subsequent commit
b1e0481
to
d035793
Compare
Build Artifacts
|
9 tasks
@AllanOXDi as this issue has been reassigned and much has happened on develop in the interim, I will close this PR for now but keep the branch for reference. Whoever takes on the related issue can review the work here as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is dependent on PR #11434 because it was branched off of it. Therefore, it would be beneficial to wait for #11434 to be merged to develop first and rebase develop to this PR.
References
closes #11016
Reviewer guidance
Please see figma design
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)