Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace question sidepanel #11497

Closed

Conversation

AllanOXDi
Copy link
Member

Summary

This PR is dependent on PR #11434 because it was branched off of it. Therefore, it would be beneficial to wait for #11434 to be merged to develop first and rebase develop to this PR.

References

closes #11016

Reviewer guidance

Please see figma design

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) SIZE: very large labels Nov 3, 2023
@AllanOXDi AllanOXDi force-pushed the replace_question_sidepanel branch from b1e0481 to d035793 Compare November 16, 2023 17:19
@nucleogenesis
Copy link
Member

@AllanOXDi as this issue has been reassigned and much has happened on develop in the interim, I will close this PR for now but keep the branch for reference. Whoever takes on the related issue can review the work here as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) SIZE: large SIZE: very large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants