Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KDS Workflows to keep KDS Roadmap statuses updated #882

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

AlexVelezLl
Copy link
Member

Description

Adds two workflows to keep KDS Roadmap statuses updated:

  1. Sync KDS Roadmap Project Statuses: Sets up a cronjob to keep KDS Roadmap project statuses synced with the Iteration backlog project items status.
  2. Update KDS Roadmap project statuses on Release: When we have a new kds release, this workflow will check all released PRs and will set their statuses to Released and will update the released in field to the release version.

Changelog

  • Description: Adds Adds two workflows to keep KDS Roadmap statuses updated
  • Products impact: none.
  • Addresses: -.
  • Components: -.
  • Breaking: no
  • Impacts a11y: no
  • Guidance: -.

Steps to test

I have tested these actions in the https://github.com/learningequality/test-actions repo. We can dispatch:

@AlexVelezLl AlexVelezLl requested review from rtibbles and MisRob January 9, 2025 19:28
@rtibbles rtibbles self-assigned this Jan 14, 2025
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always wish there was a nicer way to construct GraphQL queries than creating a string template - but that seems to be the preferred way.

As you've tested this elsewhere, I think there's no much point holding this up, so we should just merge, let it run, and make sure it's doing what it ought!

@@ -0,0 +1,206 @@
const GithubAPI = require('./GithubAPI');

const ITERATION_BACKLOG_PROJECT_NUMBER = 15;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these might be better encoded as org and repo secrets.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry - actually let's move the ids into secrets that we read in the workflow and then pass into the JS functions.

@AlexVelezLl
Copy link
Member Author

Thanks @rtibbles! I've pushed the requeseted changes :)

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secrets added at the org level and exposed to the KDS repo.

@rtibbles rtibbles merged commit 42cc436 into learningequality:develop Jan 22, 2025
9 checks passed
learning-equality-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@AlexVelezLl AlexVelezLl deleted the add-kds-workflows branch January 22, 2025 16:19
@MisRob
Copy link
Member

MisRob commented Jan 23, 2025

@AlexVelezLl @rtibbles

@EshaanAgg noted #906 - would it be possible to limit the action run to LE repo only?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants