Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding title attribute in k breadcrumbs for truncated texts#839 #872

Conversation

RONAK-AI647
Copy link
Contributor

@RONAK-AI647 RONAK-AI647 commented Dec 13, 2024

Description

It adds title attribute in KBreadcrumbs component which enable us read the truncated texts anywhere in KBreadcrumbs.

Issue addressed

Closes #208

Addresses #PR# HERE

Before/after screenshots

image

Changelog

Steps to test

1)Add title attribute in breadcrumbs-visible-items
2)Add title attribute in breadcrumbs-dropdown-wrapper
3) Please refer PR #839

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

Now the truncated texts which were not visible completely , can be seen easily .
Please refer PR #839 for reviews , code .
Reviewers:
image

@RONAK-AI647
Copy link
Contributor Author

@MisRob I have opened a new PR because rebasing the old PR was creating errors and the neutral checks where not passing .
This PR refers to the old PR #839 .Take a look , and yes the linting issues are dealt.

@MisRob MisRob self-requested a review December 16, 2024 06:19
@MisRob MisRob self-assigned this Dec 16, 2024
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @RONAK-AI647, good work here!

@MisRob MisRob merged commit 544df50 into learningequality:develop Dec 16, 2024
13 of 14 checks passed
learning-equality-bot bot pushed a commit that referenced this pull request Dec 16, 2024
@ozer550 ozer550 mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants