Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add labelDir to KCheckbox and KRadioButton #784

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Add labelDir to KCheckbox and KRadioButton #784

merged 1 commit into from
Sep 16, 2024

Conversation

AlexVelezLl
Copy link
Member

Description

Add labelDir to KCheckbox and KRadioButton to fix cases when the label dir is different from the user dir preferences.

Issue addressed

Needed to close learningequality/studio#4728.

Changelog

  • Description: Add labelDir prop to control rtl direction of label.
  • Products impact: new API.
  • Addresses: Unstable - RTL issues studio#4728.
  • Components: KCheckbox, KRadioButton.
  • Breaking: no
  • Impacts a11y: no.
  • Guidance: -.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

@AlexVelezLl AlexVelezLl changed the base branch from develop to release-v4 September 16, 2024 14:09
@AlexVelezLl AlexVelezLl changed the base branch from release-v4 to develop September 16, 2024 17:39
akolson
akolson approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM! Thanks @AlexVelezLl

@AlexVelezLl AlexVelezLl changed the base branch from develop to release-v4 September 16, 2024 21:34
@AlexVelezLl
Copy link
Member Author

Thank you @akolson!

@AlexVelezLl AlexVelezLl merged commit 1a8df33 into learningequality:release-v4 Sep 16, 2024
11 checks passed
@AlexVelezLl AlexVelezLl deleted the fix-dir-label branch September 16, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akolson akolson akolson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstable - RTL issues
2 participants
@AlexVelezLl @akolson