Add aria-checked property to KCheckbox
#572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nucleogenesis
force-pushed
the
a11y--kcheckbox-aria-checked
branch
from
b7738cf to
f9974c2
Compare
https://w3c.github.io/aria/#aria-checked can be useful information, particularly with the 'mixed' property indicating the "indeterminate" status this implements the recommendation with use of the existing props
nucleogenesis
force-pushed
the
a11y--kcheckbox-aria-checked
branch
from
a6578f8 to
9dfa73b
Compare
|
I'll take care of the changelog conflict and merge it in a moment @nucleogenesis so that we can have this available in the release that I will create later today :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was working in Kolibri I went to double check a11y stuff on the checkboxes and discovered that we should have this property applied because it can be used to indicate the same three states our KCheckbox does. What we call "indeterminate" they call "mixed", so we pass that value to the parameter easily because we have the props with all of the information we need.