Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move date-fns dependency to depencies rather than dev-dependencies. #521

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Move date-fns dependency to depencies rather than dev-dependencies. #521

merged 2 commits into from
Jan 18, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jan 16, 2024 •
edited
Loading

Description

  • Fixes bug that would happen when installing KDS in a non-Kolibri environment because of an unspecified runtime dependency

Changelog

Steps to test

  1. Install in Studio.
  2. Run devserver.
  3. See it not break.

@MisRob MisRob self-assigned this Jan 17, 2024
@MisRob MisRob self-requested a review January 17, 2024 12:53
MisRob
MisRob approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping with this, @rtibbles. The code change makes sense and I confirm I could run Studio and see it not break.

@MisRob MisRob merged commit 135a2e5 into learningequality:main Jan 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MisRob MisRob MisRob approved these changes

Assignees

@MisRob MisRob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtibbles @MisRob