Extract metadata from content pack. #4779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we generated our own dummy metadata. Now, extract the one that comes with the content pack.
|
Only adds translation metadata though. Subtitles and dubbed video counts will come soon once they're implemented on the content pack repo. |
|
Should be testable soon. Merging for further testing on develop. |
rtibbles
added a commit
that referenced
this pull request
Feb 2, 2016
Extract metadata from content pack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we generated our own dummy metadata. Now, extract the one
that comes with the content pack.
Also, there's a fix in the content pack generation side. We now properly include interface translations. See learningequality/ka-lite-content-packs@f1041d2