-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix shellscript paths for autostart, fix path for manage.py in runatboot.sh #247
Conversation
fixes #246 |
@dylanjbarth if you can pull this code and test, I will be happy to code review. If you have time for code review as well, I'm glad to "back you up" (i.e. look at it on my own as well), so you feel confident! |
discussed with @jamalex these scripts were probably modified previously to work on osx - hopefully these latest fixes are cross-platform. I don't have osx to test, so would appreciate a mac test too if poss. |
@gimick This should be perfectly fine, as all of these scripts already reference dirname ( ${BASH_SOURCE[0]} ) (from commit e346f04 ). These should be a shared method / variable across scripts. Will make that change across scripts, and do a pull request against your repo. @dylanjbarth will try this out tomorrow as well. |
Additional test cases:
We should add some regression tests for this. Will talk with @dylanjbarth about doing this. |
…wrapped in quotes.
cleanup & quoting
@dylanjbarth just retested on Linux everything seems fine, but I have found one new issue which is probably linux only - as suggested by @bcipolli,I re-installed in a folder with an embedded space, and the autostart daemon failed to start on debian. I have fixes and will push again shortly |
@dylanjbarth have just pushed 3 small changes to fix spacesin the path when autostarting. I don't know if you are able to retest linux deamon start/stop on osx, but if you can can you try this: rename "ka-lite" to "ka lite" |
Looks great; I reviewed the changes and tested start/stop on mac! |
fix shellscript paths for autostart, fix path for manage.py in runatboot.sh
fix shellscript paths for autostart, fix path for manage.py in runatboot.sh
fixes for server start linux scripts -
a) in autostart mode "service kalite start"
b) when running interactively but outside of the ka-lite working directory.
Also, fix for runatboot.sh which was failing when run interactively because of the path to the manage.py command.
To test,
i) install a system with autostart set true (i.e. with a kalite script in etc/init.rc/
ii) try the following commands without this patch:
$ ~/path to ka-lite/start.sh
$ service kalite start
$ sudo ~/path to ka-lite/kalite/runatboot.sh
iii) repeat those commands with the patch - there should be no errors