-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve bfloat16 serialization (backward compatible) #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
=======================================
Coverage 75.93% 75.93%
=======================================
Files 81 81
Lines 7982 7995 +13
=======================================
+ Hits 6061 6071 +10
- Misses 1921 1924 +3
|
I would suggest to:
|
borzunov
approved these changes
Feb 9, 2023
mryab
pushed a commit
that referenced
this pull request
Feb 15, 2023
- added bfloat16 serialization that sends 2 bytes per value (previously, we sent 4); - changed de-serialization code so it supports both modes of serialization. - the new mode can be enabled via export USE_LEGACY_BFLOAT16=0 - tested in pytorch 1.12 and 1.13 --------- Co-authored-by: Aleksandr Borzunov <[email protected]> (cherry picked from commit 7d1bb7d)
borzunov
added a commit
that referenced
this pull request
Mar 28, 2023
mryab
pushed a commit
that referenced
this pull request
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
export LEGACY_BFLOAT16=0
Next minor release: switch to new serialization mode
Next major release: remove legacy mode